From: Jeff King <peff@peff.net>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] git-init.txt: do not nest open blocks
Date: Sun, 16 Dec 2018 05:55:05 -0500 [thread overview]
Message-ID: <20181216105505.GE13704@sigill.intra.peff.net> (raw)
In-Reply-To: <20181215112742.1475882-3-martin.agren@gmail.com>
On Sat, Dec 15, 2018 at 12:27:40PM +0100, Martin Ågren wrote:
> It appears we try to nest open blocks, but that does not work well with
> Asciidoctor, which fails to indent the inner block. This causes the
> inner block to be set as if it had nothing to do with `--shared`. Drop
> the outer one. Asciidoc renders identically before and after this patch,
> both man-page and html.
Hrm. I'm not sure how we're supposed to have a block-within-a-block in
asciidoctor, and that may be something we want to fix in the long run.
But I agree this block around all of the options is not doing anything
useful, and the simplest solution here is just to get rid of it.
It dates all the way back to d145144c3b (Document git-init, 2007-01-11),
so perhaps it did something useful in an ancient version of asciidoc.
-Peff
next prev parent reply other threads:[~2018-12-16 10:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 11:27 [PATCH 0/4] A few Asciidoctor-fixes Martin Ågren
2018-12-15 11:27 ` [PATCH 1/4] git-column.txt: fix section header Martin Ågren
2018-12-16 10:51 ` Jeff King
2018-12-16 14:27 ` Martin Ågren
2018-12-15 11:27 ` [PATCH 2/4] git-init.txt: do not nest open blocks Martin Ågren
2018-12-16 10:55 ` Jeff King [this message]
2018-12-15 11:27 ` [PATCH 3/4] rev-list-options.txt: " Martin Ågren
2018-12-16 10:56 ` Jeff King
2018-12-15 11:27 ` [PATCH 4/4] git-status.txt: render tables correctly under Asciidoctor Martin Ågren
2018-12-16 10:59 ` Jeff King
2018-12-16 14:28 ` [PATCH v2 0/3] A few Asciidoctor-fixes Martin Ågren
2018-12-16 14:28 ` [PATCH v2 1/3] git-column.txt: fix section header Martin Ågren
2018-12-16 14:28 ` [PATCH v2 2/3] Documentation: do not nest open blocks Martin Ågren
2018-12-16 14:28 ` [PATCH v2 3/3] git-status.txt: render tables correctly under Asciidoctor Martin Ågren
2018-12-16 16:19 ` [PATCH v2 0/3] A few Asciidoctor-fixes Jeff King
2018-12-16 10:44 ` [PATCH 0/4] " Jeff King
2018-12-16 14:34 ` Martin Ågren
2018-12-16 16:17 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181216105505.GE13704@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).