From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Paul Morelle <paul.morelle@gmail.com>,
Git Users <git@vger.kernel.org>
Subject: Re: [PATCH] rebase -i: introduce the 'test' command
Date: Mon, 3 Dec 2018 16:34:19 -0500 [thread overview]
Message-ID: <20181203213419.GE8700@sigill.intra.peff.net> (raw)
In-Reply-To: <20181203175322.GA3892@duynguyen.home>
On Mon, Dec 03, 2018 at 06:53:22PM +0100, Duy Nguyen wrote:
> On Sat, Dec 01, 2018 at 03:02:09PM -0500, Jeff King wrote:
> > I sometimes add "x false" to the top of the todo list to stop and create
> > new commits before the first one.
>
> And here I've been doing the same by "edit" the first commit, add a
> new commit then reorder them in the second interactive rebase :P
>
> This made me look at git-rebase.txt to really learn about interactive
> rebase. I think the interactive rebase section could use some
> improvements. Its style looks.. umm.. more story telling than a
> reference. Perhaps something like this to at least highlight the
> commands.
Yeah, I think the typographic change is an improvement that doesn't
really have a downside.
As Dscho mentioned, sometimes the story style is what you want, so I
don't think we'd want to simply rearrange it. It may be useful to
present the material twice, though: once as a table/list for reference,
and then once as a story working through an example.
-Peff
prev parent reply other threads:[~2018-12-03 21:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 13:28 [PATCH] rebase -i: introduce the 'test' command Paul Morelle
2018-11-28 15:19 ` Johannes Schindelin
2018-11-28 16:56 ` Paul Morelle
2018-11-29 8:32 ` Johannes Schindelin
2018-11-29 10:55 ` Johannes Schindelin
2018-12-01 20:02 ` Jeff King
2018-12-02 2:28 ` Eric Sunshine
2018-12-02 3:31 ` Jeff King
2018-12-11 12:40 ` Ævar Arnfjörð Bjarmason
2018-12-11 14:11 ` Jeff King
2018-12-02 19:48 ` Johannes Schindelin
2018-12-03 14:31 ` Phillip Wood
2018-12-03 21:27 ` Jeff King
2018-12-03 17:27 ` Luc Van Oostenryck
2018-12-03 19:01 ` Johannes Schindelin
2018-12-03 19:34 ` Luc Van Oostenryck
2018-12-03 21:31 ` Jeff King
2018-12-04 9:13 ` Johannes Schindelin
2018-12-03 17:53 ` Duy Nguyen
2018-12-03 19:03 ` Johannes Schindelin
2018-12-03 21:34 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203213419.GE8700@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=paul.morelle@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).