From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH 0/5] Make :(attr) pathspec work with "git log"
Date: Sun, 18 Nov 2018 17:47:55 +0100 [thread overview]
Message-ID: <20181118164800.32759-1-pclouds@gmail.com> (raw)
When :(attr) was added, it supported one of the two main pathspec
matching functions, the one that works on a list of paths. The other
one works on a tree, tree_entry_interesting(), which gets :(attr)
support in this series.
With this, "git grep <pattern> <tree> -- :(attr)" or "git log :(attr)"
will not abort with BUG() anymore.
But this also reveals an interesting thing: even though we walk on a
tree, we check attributes from _worktree_ (and optionally fall back to
the index). This is how attributes are implemented since forever. I
think this is not a big deal if we communicate clearly with the user.
But otherwise, this series can be scraped, as reading attributes from
a specific tree could be a lot of work.
The main patch is the last one. The others are just to open a path to
pass "struct index_state *" down to tree_entry_interesting(). This may
become standard procedure because we don't want to stick the_index (or
the_repository) here and there.
Nguyễn Thái Ngọc Duy (5):
tree.c: make read_tree*() take 'struct repository *'
tree-walk.c: make tree_entry_interesting() take an index
pathspec.h: clean up "extern" in function declarations
dir.c: move, rename and export match_attrs()
tree-walk: support :(attr) matching
Documentation/glossary-content.txt | 2 +
archive.c | 6 +-
builtin/checkout.c | 3 +-
builtin/grep.c | 3 +-
builtin/log.c | 5 +-
builtin/ls-files.c | 2 +-
builtin/ls-tree.c | 3 +-
builtin/merge-tree.c | 2 +-
dir.c | 41 +-------------
list-objects.c | 3 +-
merge-recursive.c | 3 +-
pathspec.c | 38 +++++++++++++
pathspec.h | 27 +++++----
revision.c | 1 +
t/t6135-pathspec-with-attrs.sh | 58 ++++++++++++++++++-
tree-diff.c | 3 +-
tree-walk.c | 89 ++++++++++++++++++++++--------
tree-walk.h | 10 ++--
tree.c | 21 ++++---
tree.h | 18 +++---
unpack-trees.c | 6 +-
21 files changed, 235 insertions(+), 109 deletions(-)
--
2.19.1.1327.g328c130451.dirty
next reply other threads:[~2018-11-18 16:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 16:47 Nguyễn Thái Ngọc Duy [this message]
2018-11-18 16:47 ` [PATCH 1/5] tree.c: make read_tree*() take 'struct repository *' Nguyễn Thái Ngọc Duy
2018-11-18 16:47 ` [PATCH 2/5] tree-walk.c: make tree_entry_interesting() take an index Nguyễn Thái Ngọc Duy
2018-11-18 16:47 ` [PATCH 3/5] pathspec.h: clean up "extern" in function declarations Nguyễn Thái Ngọc Duy
2018-11-18 16:47 ` [PATCH 4/5] dir.c: move, rename and export match_attrs() Nguyễn Thái Ngọc Duy
2018-11-18 16:48 ` [PATCH 5/5] tree-walk: support :(attr) matching Nguyễn Thái Ngọc Duy
2018-11-18 19:58 ` Ævar Arnfjörð Bjarmason
2018-11-19 15:33 ` Duy Nguyen
2018-11-18 19:51 ` [PATCH 0/5] Make :(attr) pathspec work with "git log" Ævar Arnfjörð Bjarmason
2018-11-19 11:16 ` Ævar Arnfjörð Bjarmason
2018-11-19 15:25 ` Duy Nguyen
2018-11-19 12:09 ` Jeff King
2018-11-19 1:49 ` Junio C Hamano
2018-11-19 11:42 ` Ævar Arnfjörð Bjarmason
2018-11-19 15:31 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181118164800.32759-1-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).