From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Jeff King" <peff@peff.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Michael Haggerty" <mhagger@alum.mit.edu>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH v2] read-cache: write all indexes with the same permissions
Date: Fri, 16 Nov 2018 19:29:34 +0100 [thread overview]
Message-ID: <20181116182934.GN30222@szeder.dev> (raw)
In-Reply-To: <20181116173105.21784-1-chriscool@tuxfamily.org>
On Fri, Nov 16, 2018 at 06:31:05PM +0100, Christian Couder wrote:
> diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh
> index 2ac47aa0e4..fa1d3d468b 100755
> --- a/t/t1700-split-index.sh
> +++ b/t/t1700-split-index.sh
> @@ -381,6 +381,26 @@ test_expect_success 'check splitIndex.sharedIndexExpire set to "never" and "now"
> test $(ls .git/sharedindex.* | wc -l) -le 2
> '
>
> +test_expect_success POSIXPERM 'same mode for index & split index' '
> + git init same-mode &&
> + (
> + cd same-mode &&
> + test_commit A &&
> + test_modebits .git/index >index_mode &&
> + test_must_fail git config core.sharedRepository &&
> + git -c core.splitIndex=true status &&
> + shared=$(ls .git/sharedindex.*) &&
I think the command substitution and 'ls' are unnecessary, and
shared=.git/sharedindex.*
would work as well.
> + case "$shared" in
> + *" "*)
> + # we have more than one???
> + false ;;
> + *)
> + test_modebits "$shared" >split_index_mode &&
> + test_cmp index_mode split_index_mode ;;
> + esac
> + )
> +'
> +
> while read -r mode modebits
> do
> test_expect_success POSIXPERM "split index respects core.sharedrepository $mode" '
> --
> 2.19.1.1053.g063ed687ac
>
next prev parent reply other threads:[~2018-11-16 18:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 17:31 [PATCH v2] read-cache: write all indexes with the same permissions Christian Couder
2018-11-16 18:02 ` Duy Nguyen
2018-11-16 19:10 ` Christian Couder
2018-11-16 19:16 ` Duy Nguyen
2018-11-16 18:29 ` SZEDER Gábor [this message]
2018-11-16 19:25 ` Ævar Arnfjörð Bjarmason
2018-11-16 19:25 ` Christian Couder
2018-11-17 8:57 ` Junio C Hamano
2018-11-17 12:24 ` SZEDER Gábor
2018-11-17 9:29 ` Junio C Hamano
2018-11-17 11:19 ` Christian Couder
2018-11-17 13:05 ` Junio C Hamano
2018-11-17 21:14 ` Ævar Arnfjörð Bjarmason
2018-11-18 7:09 ` Junio C Hamano
2018-11-18 12:03 ` Ævar Arnfjörð Bjarmason
2018-11-18 19:04 ` [PATCH v3] read-cache: make the split index obey umask settings Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116182934.GN30222@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).