From: Jonathan Tan <jonathantanmy@google.com> To: gitster@pobox.com Cc: jonathantanmy@google.com, peff@peff.net, git@vger.kernel.org Subject: Re: [PATCH 1/2] ls-remote: do not send ref prefixes for patterns Date: Thu, 8 Nov 2018 12:52:49 -0800 [thread overview] Message-ID: <20181108205249.195494-1-jonathantanmy@google.com> (raw) In-Reply-To: <xmqq7ehyybnd.fsf@gitster-ct.c.googlers.com> > Jeff King <peff@peff.net> writes: > > > Since b4be74105f (ls-remote: pass ref prefixes when requesting a > > remote's refs, 2018-03-15), "ls-remote foo" will pass "refs/heads/foo", > > "refs/tags/foo", etc to the transport code in an attempt to let the > > other side reduce the size of its advertisement. > > Jonathan, seeing 2b554353 ("fetch: send "refs/tags/" prefix upon CLI > refspecs", 2018-06-05), I am guessing that you are doing the proto v2 > work inherited from Brandon? Sorry for the late reply - I had some personal events, but I should be able to look more at Git stuff from now on. Well, it's true that I have been fixing some bugs related to protocol v2. > Having to undo this is unfortunate, but > I agree with this patch that we need to do this until ref prefix learns > to grok wildcards. It is unfortunate, although as far as I can tell, the performance improvements from "git fetch" (which I think is the more frequent command called) remain, so it might not be so bad. I see from your What's Cooking that these patches are to be merged to master, which I agree with.
next prev parent reply other threads:[~2018-11-08 20:52 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-31 4:23 [PATCH 0/2] ls-remote and v2 ref prefixes Jeff King 2018-10-31 4:24 ` [PATCH 1/2] ls-remote: do not send ref prefixes for patterns Jeff King 2018-10-31 4:37 ` Junio C Hamano 2018-11-08 20:52 ` Jonathan Tan [this message] 2018-10-31 4:24 ` [PATCH 2/2] ls-remote: pass heads/tags prefixes to transport Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181108205249.195494-1-jonathantanmy@google.com \ --to=jonathantanmy@google.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=peff@peff.net \ --subject='Re: [PATCH 1/2] ls-remote: do not send ref prefixes for patterns' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).