From: Jeff King <peff@peff.net>
To: chris via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
chris <chris@webstech.net>
Subject: Re: [PATCH 1/1] Use correct /dev/null for UNIX and Windows
Date: Tue, 30 Oct 2018 23:56:18 -0400 [thread overview]
Message-ID: <20181031035618.GA31247@sigill.intra.peff.net> (raw)
In-Reply-To: <8159cbd1b8025f33fb9d0e254db1a3c2a066f853.1540923993.git.gitgitgadget@gmail.com>
On Tue, Oct 30, 2018 at 11:26:36AM -0700, chris via GitGitGadget wrote:
> From: chris <chris@webstech.net>
You might want to adjust your user.name. :)
> Use File::Spec->devnull() for output redirection to avoid messages
> when Windows version of Perl is first in path. The message 'The
> system cannot find the path specified.' is displayed each time git is
> run to get colors.
Thanks, makes sense, and the patch looks good to me.
-Peff
next prev parent reply other threads:[~2018-10-31 3:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 18:26 [PATCH 0/1] DiffHighlight.pm: Use correct /dev/null for UNIX and Windows Chris. Webster via GitGitGadget
2018-10-30 18:26 ` [PATCH 1/1] " chris via GitGitGadget
2018-10-31 3:56 ` Jeff King [this message]
2018-10-31 4:48 ` Junio C Hamano
2018-10-31 4:54 ` Junio C Hamano
[not found] ` <CAGT1KpWoGD0xgTrC-+X1WqY_M=2arYbs4ZX6Nnj-zHK6mgu+nw@mail.gmail.com>
2018-10-31 5:41 ` Chris Webster
2018-10-31 6:08 ` Junio C Hamano
2018-10-31 11:10 ` Johannes Schindelin
2018-11-01 1:57 ` Junio C Hamano
2018-10-31 5:07 ` Junio C Hamano
2018-10-31 11:14 ` Johannes Schindelin
2018-10-31 22:58 ` [PATCH v2 0/1] DiffHighlight.pm: " Chris. Webster via GitGitGadget
[not found] ` <bcbffa141116f869db40e4572f9824a3d090c20c.1541026721.git.gitgitgadget@gmail.com>
2018-11-06 14:01 ` [PATCH v2 1/1] diff-highlight: " Johannes Schindelin
2019-05-07 4:18 ` Chris Webster
2019-05-12 20:24 ` Philip Oakley
2019-05-08 10:45 ` Fwd: " Git Gadget
2019-05-09 3:19 ` Junio C Hamano
2019-05-09 18:52 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031035618.GA31247@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=chris@webstech.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).