From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] test-lib: introduce the '-V' short option for '--verbose-log'
Date: Mon, 29 Oct 2018 11:42:28 -0400 [thread overview]
Message-ID: <20181029154228.GA27538@sigill.intra.peff.net> (raw)
In-Reply-To: <20181029135335.GS30222@szeder.dev>
On Mon, Oct 29, 2018 at 02:53:35PM +0100, SZEDER Gábor wrote:
> > Interesting. I'm not opposed to something like this, but I added
> > "--verbose-log" specifically for scripted cases, like running an
> > unattended "prove" that needs to preserve stdout. When running
> > individual tests, I'd just use "-v" itself, and possibly redirect the
> > output.
> >
> > For my curiosity, can you describe your use case a bit more?
>
> Even when I run individual test scripts by hand, I prefer to have a
> file catching all output of the test, because I don't like it when the
> test output floods my terminal (especially with '-x'), and because the
> file is searchable but the terminal isn't. And that's exactly what
> '--verbose-log' does.
>
> Redirecting the '-v' output (i.e. stdout) alone is insufficient,
> because any error messages within the tests and the '-x' trace go to
> stderr, so they still end up on the terminal. Therefore I would have
> to remember to redirect stderr every time as well.
>
> I find it's much easier to just always use '--verbose-log'... except
> for the length of the option, that is, hence this patch.
OK, fair enough. Maybe I should start using "-V" too, then. ;)
(I find myself most often coupling "-v" with "-i" to stop at the failure
and just read what's left on the screen).
-Peff
prev parent reply other threads:[~2018-10-29 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 12:13 [PATCH] test-lib: introduce the '-V' short option for '--verbose-log' SZEDER Gábor
2018-10-29 14:21 ` Jeff King
2018-10-29 13:53 ` SZEDER Gábor
2018-10-29 15:42 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029154228.GA27538@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).