git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: pclouds@gmail.com, peff@peff.net, chriscool@tuxfamily.org,
	l.s.r@web.de, ramsay@ramsayjones.plus.com,
	"Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: [PATCH v3 3/3] commit-slab: missing definitions and forward declarations (hdr-check)
Date: Thu, 25 Oct 2018 04:04:27 -0700	[thread overview]
Message-ID: <20181025110427.13655-4-carenas@gmail.com> (raw)
In-Reply-To: <20181025110427.13655-1-carenas@gmail.com>

struct commmit needs to be defined before commit-slab can generate
working code, object_id should be at least known through a forward
declaration

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 commit-slab-impl.h | 2 ++
 commit-slab.h      | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/commit-slab-impl.h b/commit-slab-impl.h
index e352c2f8c1..db7cf3f19b 100644
--- a/commit-slab-impl.h
+++ b/commit-slab-impl.h
@@ -1,6 +1,8 @@
 #ifndef COMMIT_SLAB_IMPL_H
 #define COMMIT_SLAB_IMPL_H
 
+#include "commit.h"
+
 #define implement_static_commit_slab(slabname, elemtype) \
 	implement_commit_slab(slabname, elemtype, MAYBE_UNUSED static)
 
diff --git a/commit-slab.h b/commit-slab.h
index 69bf0c807c..722252de61 100644
--- a/commit-slab.h
+++ b/commit-slab.h
@@ -1,6 +1,8 @@
 #ifndef COMMIT_SLAB_H
 #define COMMIT_SLAB_H
 
+struct object_id;
+
 #include "commit-slab-decl.h"
 #include "commit-slab-impl.h"
 
-- 
2.19.1


  parent reply	other threads:[~2018-10-25 11:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 11:04 [PATCH v3 0/3] delta-islands: avoid unused function messages Carlo Marcelo Arenas Belón
2018-10-25 11:04 ` [PATCH v3 1/3] commit-slab: move MAYBE_UNUSED into git-compat-util Carlo Marcelo Arenas Belón
2018-10-25 11:04 ` [PATCH v3 2/3] khash: silence -Wunused-function in delta-islands from khash Carlo Marcelo Arenas Belón
2018-10-25 11:30   ` SZEDER Gábor
2018-10-25 11:04 ` Carlo Marcelo Arenas Belón [this message]
2018-10-25 18:54   ` [PATCH v3 3/3] commit-slab: missing definitions and forward declarations (hdr-check) Ramsay Jones
2018-10-25 21:08     ` Ramsay Jones
2018-10-26  3:15       ` Carlo Arenas
2018-10-27  1:45         ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025110427.13655-4-carenas@gmail.com \
    --to=carenas@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).