From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id B15141F453 for ; Tue, 23 Oct 2018 17:35:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728462AbeJXB7Z (ORCPT ); Tue, 23 Oct 2018 21:59:25 -0400 Received: from cloud.peff.net ([104.130.231.41]:51288 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728092AbeJXB7Z (ORCPT ); Tue, 23 Oct 2018 21:59:25 -0400 Received: (qmail 32536 invoked by uid 109); 23 Oct 2018 17:35:07 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 23 Oct 2018 17:35:07 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23410 invoked by uid 111); 23 Oct 2018 17:34:19 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Tue, 23 Oct 2018 13:34:19 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 23 Oct 2018 13:35:04 -0400 Date: Tue, 23 Oct 2018 13:35:04 -0400 From: Jeff King To: Ben Peart Cc: Ramsay Jones , git@vger.kernel.org, gitster@pobox.com, benpeart@microsoft.com, sunshine@sunshineco.com Subject: Re: [PATCH v3 2/3] reset: add new reset.quiet config setting Message-ID: <20181023173504.GA2076@sigill.intra.peff.net> References: <20181017164021.15204-1-peartben@gmail.com> <20181022131828.21348-1-peartben@gmail.com> <20181022131828.21348-3-peartben@gmail.com> <045b78ce-230e-86fe-6e5a-684bf9e93fbc@ramsayjones.plus.com> <20181022200601.GC9917@sigill.intra.peff.net> <6feb67a1-17fa-4280-9e31-963b619fa051@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6feb67a1-17fa-4280-9e31-963b619fa051@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Oct 23, 2018 at 01:31:58PM -0400, Ben Peart wrote: > On 10/22/2018 4:06 PM, Jeff King wrote: > > On Mon, Oct 22, 2018 at 08:13:32PM +0100, Ramsay Jones wrote: > > > > > > -q:: > > > > --quiet:: > > > > - Be quiet, only report errors. > > > > +--no-quiet:: > > > > + Be quiet, only report errors. The default behavior respects the > > > > + `reset.quiet` config option, or `--no-quiet` if that is not set. > > > > > > Sorry, I can't quite parse this; -q,--quiet and --no-quiet on the > > > command line (should) trump whatever rest.quiet is set to in the > > > configuration. Is that not the case? > > > > That is the case, and what was meant by "the default behavior" (i.e., > > the behavior when none of these is used). Maybe there's a more clear way > > of saying that. > > > > Is this more clear? > > -q:: > --quiet:: > --no-quiet:: > Be quiet, only report errors. The default behavior is set by the > `reset.quiet` config option. `--quiet` and `--no-quiet` will > overwrite the default behavior. That looks OK to me (but then so did the earlier one ;) ). I'd probably s/overwrite/override/. -Peff