From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] builtin/submodule--helper: remove debugging leftover tracing
Date: Tue, 16 Oct 2018 19:52:13 -0700 [thread overview]
Message-ID: <20181017025213.GB117170@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20181016234550.216587-1-sbeller@google.com>
Stefan Beller wrote:
> I noticed 74d4731da1 (submodule--helper: replace connect-gitdir-workingtree
> by ensure-core-worktree, 2018-08-13) had two leftover debugging statements
> when reading The coverage report [1]. Remove them.
>
> https://public-inbox.org/git/e30a9c05-87d8-1f2b-182c-6d6a5fefe43c@gmail.com/
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> builtin/submodule--helper.c | 2 --
> 1 file changed, 2 deletions(-)
Doh. Glad you caught it!
Is there some reference for The Coverage Report other than the mailing
list? E.g. I suspect a reference to
make coverage-test
make coverage-report
would be useful to readers finding this commit later.
> To be applied on (or squashed into the tip of)
> sb/submodule-update-in-c
Looks like that's already in "master", so not a candidate for
squashing.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
prev parent reply other threads:[~2018-10-17 2:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 23:45 [PATCH] builtin/submodule--helper: remove debugging leftover tracing Stefan Beller
2018-10-17 2:52 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017025213.GB117170@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).