From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 53C661F453 for ; Tue, 16 Oct 2018 06:33:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727227AbeJPOWT (ORCPT ); Tue, 16 Oct 2018 10:22:19 -0400 Received: from cloud.peff.net ([104.130.231.41]:41816 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727094AbeJPOWT (ORCPT ); Tue, 16 Oct 2018 10:22:19 -0400 Received: (qmail 18919 invoked by uid 109); 16 Oct 2018 06:33:26 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 16 Oct 2018 06:33:26 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 7857 invoked by uid 111); 16 Oct 2018 06:32:36 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Tue, 16 Oct 2018 02:32:36 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 16 Oct 2018 02:33:23 -0400 Date: Tue, 16 Oct 2018 02:33:23 -0400 From: Jeff King To: Junio C Hamano Cc: Brendan Forster via GitGitGadget , git@vger.kernel.org, Brendan Forster Subject: Re: [PATCH 2/3] http: add support for disabling SSL revocation checks in cURL Message-ID: <20181016063323.GA25933@sigill.intra.peff.net> References: <764791d13d20478639402e7af95e901223444240.1539598481.git.gitgitgadget@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Oct 16, 2018 at 01:23:25PM +0900, Junio C Hamano wrote: > > +#if LIBCURL_VERSION_NUM >= 0x072c00 > > + curl_easy_setopt(result, CURLOPT_SSL_OPTIONS, CURLSSLOPT_NO_REVOKE); > > +#else > > + warning("CURLSSLOPT_NO_REVOKE not applied to curl SSL options because\n" > > + "your curl version is too old (>= 7.44.0)"); > > +#endif > > That ">=" is hard to grok. I think you meant it to be pronounced > "requries at least", but that is not a common reading. People more > commonly pronounce it "is greater than or equal to". This seemed oddly familiar: https://public-inbox.org/git/8da9d436-88b9-7959-dd9c-65bdd376bf54@mail.mipt.ru/ Since this one is clearly copied from there, it may be worth fixing the original. -Peff