From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Thomas Gummerer <t.gummerer@gmail.com>,
git@vger.kernel.org, Josh Steadmon <steadmon@google.com>
Subject: Re: [PATCH] config.mak.dev: add -Wformat
Date: Fri, 12 Oct 2018 15:11:35 -0400 [thread overview]
Message-ID: <20181012191134.GE4917@sigill.intra.peff.net> (raw)
In-Reply-To: <20181012185450.GB52080@aiede.svl.corp.google.com>
On Fri, Oct 12, 2018 at 11:54:50AM -0700, Jonathan Nieder wrote:
> > I'm not opposed to making config.mak.dev a bit more redundant to handle
> > this case, but we'd probably want to include all of -Wall, since it
> > contains many other warnings we'd want to make sure are enabled.
>
> Do you mean putting -Wall instead of -Wformat?
Yes.
> Should we add -Wextra too? From a quick test, it seems to build okay.
We already do (though we have to then manually disable a few warnings
that we're not ready for -- see config.mak.dev).
-Peff
next prev parent reply other threads:[~2018-10-12 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 18:40 [PATCH] config.mak.dev: add -Wformat Thomas Gummerer
2018-10-12 18:45 ` Jeff King
2018-10-12 18:54 ` Jonathan Nieder
2018-10-12 19:11 ` Jeff King [this message]
2018-10-12 19:15 ` Thomas Gummerer
2018-12-27 18:59 ` Jonathan Nieder
2019-01-03 16:55 ` Junio C Hamano
2019-01-03 18:54 ` Jonathan Nieder
2019-01-06 18:17 ` Thomas Gummerer
2019-01-07 17:04 ` Junio C Hamano
2019-01-07 21:16 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012191134.GE4917@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=steadmon@google.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).