git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
* [PATCH] doc: move git-cherry to plumbing
@ 2018-10-11 18:33 Daniels Umanovskis
  2018-11-01 17:13 ` Duy Nguyen
  0 siblings, 1 reply; 2+ messages in thread
From: Daniels Umanovskis @ 2018-10-11 18:33 UTC (permalink / raw)
  To: git; +Cc: Daniels Umanovskis

Also remove git-cherry from Bash completion because plumbing
commands do not belong there.

Signed-off-by: Daniels Umanovskis <daniels@umanovskis.se>
---

Up to discussion whether cherry should be considered plumbing.
I lean towards considering it a rarely-used porcelain command, but
a case could be made either way so let's see what the list thinks.

 command-list.txt                       |  2 +-
 contrib/completion/git-completion.bash | 11 -----------
 2 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/command-list.txt b/command-list.txt
index c36ea3c18..bdca6e3d3 100644
--- a/command-list.txt
+++ b/command-list.txt
@@ -62,7 +62,7 @@ git-check-mailmap                       purehelpers
 git-checkout                            mainporcelain           history
 git-checkout-index                      plumbingmanipulators
 git-check-ref-format                    purehelpers
-git-cherry                              ancillaryinterrogators          complete
+git-cherry                              plumbinginterrogators          complete
 git-cherry-pick                         mainporcelain
 git-citool                              mainporcelain
 git-clean                               mainporcelain
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d63d2dffd..12f7ce0c5 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1340,17 +1340,6 @@ _git_checkout ()
 	esac
 }
 
-_git_cherry ()
-{
-	case "$cur" in
-	--*)
-		__gitcomp_builtin cherry
-		return
-	esac
-
-	__git_complete_refs
-}
-
 __git_cherry_pick_inprogress_options="--continue --quit --abort"
 
 _git_cherry_pick ()
-- 
2.19.1.330.g93276587c.dirty


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] doc: move git-cherry to plumbing
  2018-10-11 18:33 [PATCH] doc: move git-cherry to plumbing Daniels Umanovskis
@ 2018-11-01 17:13 ` Duy Nguyen
  0 siblings, 0 replies; 2+ messages in thread
From: Duy Nguyen @ 2018-11-01 17:13 UTC (permalink / raw)
  To: daniels; +Cc: Git Mailing List

On Thu, Oct 11, 2018 at 9:38 PM Daniels Umanovskis
<daniels@umanovskis.se> wrote:
>
> Also remove git-cherry from Bash completion because plumbing
> commands do not belong there.

Er.. why?

>
> Signed-off-by: Daniels Umanovskis <daniels@umanovskis.se>
> ---
>
> Up to discussion whether cherry should be considered plumbing.
> I lean towards considering it a rarely-used porcelain command, but
> a case could be made either way so let's see what the list thinks.
>
>  command-list.txt                       |  2 +-
>  contrib/completion/git-completion.bash | 11 -----------
>  2 files changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/command-list.txt b/command-list.txt
> index c36ea3c18..bdca6e3d3 100644
> --- a/command-list.txt
> +++ b/command-list.txt
> @@ -62,7 +62,7 @@ git-check-mailmap                       purehelpers
>  git-checkout                            mainporcelain           history
>  git-checkout-index                      plumbingmanipulators
>  git-check-ref-format                    purehelpers
> -git-cherry                              ancillaryinterrogators          complete
> +git-cherry                              plumbinginterrogators          complete
>  git-cherry-pick                         mainporcelain
>  git-citool                              mainporcelain
>  git-clean                               mainporcelain
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d63d2dffd..12f7ce0c5 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1340,17 +1340,6 @@ _git_checkout ()
>         esac
>  }
>
> -_git_cherry ()
> -{
> -       case "$cur" in
> -       --*)
> -               __gitcomp_builtin cherry
> -               return
> -       esac
> -
> -       __git_complete_refs

I think this is a regression. Because now "git cherry <tab>" will not
complete refs (the default completer can still complete "git cherry
--<tab>" fine). We support option completion of all commands no matter
what categeory they are. The category is mostly to hide them from "git
<tab>".

If you just want to hide "git cherry" from the "git <tab>" list, then
you could remove the "complete" tag in command-list.txt above.

> -}
> -
>  __git_cherry_pick_inprogress_options="--continue --quit --abort"
>
>  _git_cherry_pick ()
> --
> 2.19.1.330.g93276587c.dirty
>


-- 
Duy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-11 18:33 [PATCH] doc: move git-cherry to plumbing Daniels Umanovskis
2018-11-01 17:13 ` Duy Nguyen

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox