From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Jacob Keller <jacob.keller@gmail.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH v3] coccicheck: process every source file at once
Date: Fri, 5 Oct 2018 20:39:04 +0200 [thread overview]
Message-ID: <20181005183904.GV23446@localhost> (raw)
In-Reply-To: <20181005162517.GB11254@sigill.intra.peff.net>
On Fri, Oct 05, 2018 at 12:25:17PM -0400, Jeff King wrote:
> On Fri, Oct 05, 2018 at 02:40:48PM +0200, SZEDER Gábor wrote:
>
> > On Thu, Oct 04, 2018 at 07:17:47PM -0700, Jacob Keller wrote:
> > > Junio, do you want me to update the commit message on my side with the
> > > memory concerns? Or could you update it to mention memory as a noted
> > > trade off.
> >
> > We have been running 'make -j2 coccicheck' in the static analysis
> > build job on Travis CI, which worked just fine so far. The Travis CI
> > build environments have 3GB of memory available [1], but, as shown in
> > [2], with this patch the memory consumption jumps up to about
> > 1.3-1.8GB for each of those jobs. So with two parallel jobs we will
> > very likely bump into this limit.
> >
> > So this patch should definitely change that build script to run only a
> > single job.
>
> It should still be a net win, since the total CPU seems to drop by a
> factor of 3-4.
Well, that's true when you have unlimited resources... :) or it's
true even then, when I have just enough resources, but not much
contention. After all, Coccinelle doesn't have to parse the same
header files over and over again. However, on Travis CI, where who
knows how many other build jobs are running next to our static
analysis, it doesn't seem to be the case.
On current master with an additional 'time' in front:
time make --jobs=2 coccicheck
<...>
695.70user 50.27system 6:27.88elapsed 192%CPU (0avgtext+0avgdata 91448maxresident)k
5976inputs+2536outputs (42major+18411888minor)pagefaults 0swaps
https://travis-ci.org/szeder/git/jobs/437733874#L574
With this patch, but without -j2 to fit into 3GB:
960.50user 22.59system 16:23.74elapsed 99%CPU (0avgtext+0avgdata 1606156maxresident)k
5976inputs+1320outputs (26major+4548440minor)pagefaults 0swaps
https://travis-ci.org/szeder/git/jobs/437734003#L575
Note that both the runtime and the CPU time increased. (and RSS, of
course)
> Are we OK with saying 1.3-1.8GB is necessary to run coccicheck? That
> doesn't feel like an exorbitant request for a developer-only tool these
> days, but I have noticed some people on the list tend to have lousier
> machines than I do. ;)
>
> -Peff
next prev parent reply other threads:[~2018-10-05 18:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 20:07 [PATCH v3] coccicheck: process every source file at once Jacob Keller
2018-10-02 20:18 ` Jacob Keller
2018-10-05 2:17 ` Jacob Keller
2018-10-05 12:40 ` SZEDER Gábor
2018-10-05 16:25 ` Jeff King
2018-10-05 16:53 ` Keller, Jacob E
2018-10-05 16:59 ` Jeff King
2018-10-05 18:50 ` SZEDER Gábor
2018-10-05 19:00 ` Jeff King
2018-10-05 23:10 ` Jacob Keller
2018-10-06 8:42 ` René Scharfe
2018-10-09 3:11 ` Jeff King
2018-10-05 18:39 ` SZEDER Gábor [this message]
2018-10-05 19:02 ` Jeff King
2018-10-05 19:54 ` SZEDER Gábor
2018-10-09 3:15 ` Jeff King
2018-10-10 11:44 ` SZEDER Gábor
2018-10-10 13:59 ` Jeff King
2018-10-07 11:36 ` Beat Bolli
2018-10-07 11:49 ` Beat Bolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005183904.GV23446@localhost \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).