From: Jeff King <peff@peff.net>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t1400: drop debug `echo` to actually execute `test`
Date: Sat, 29 Sep 2018 04:00:16 -0400 [thread overview]
Message-ID: <20180929080016.GH2174@sigill.intra.peff.net> (raw)
In-Reply-To: <20180928154359.26919-1-martin.agren@gmail.com>
On Fri, Sep 28, 2018 at 05:43:59PM +0200, Martin Ågren wrote:
> Instead of running `test "foo" = "$(bar)"`, we prefix the whole thing
> with `echo`. Comparing to nearby tests makes it clear that this is just
> debug leftover. This line has actually been modified four times since it
> was introduced in e52290428b (General ref log reading improvements.,
> 2006-05-19) and the `echo` has always survived. Let's finally drop it.
Hmm, yeah. I cannot see how this echo was ever accomplishing anything.
> This script could need some more cleanups. This is just an immediate fix
> so that we actually test what we intend to.
Yeah, this is definitely worth doing now, and not holding hostage to a
bigger cleanup.
> ---
> t/t1400-update-ref.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The patch looks good to me. Thanks!
-Peff
prev parent reply other threads:[~2018-09-29 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 15:43 [PATCH] t1400: drop debug `echo` to actually execute `test` Martin Ågren
2018-09-29 8:00 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929080016.GH2174@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).