From: Jeff King <peff@peff.net>
To: Stas Bekman <stas@stason.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: git diff-tree ignores --textconv
Date: Sun, 23 Sep 2018 21:23:54 -0400 [thread overview]
Message-ID: <20180924012354.GA27439@sigill.intra.peff.net> (raw)
In-Reply-To: <13dec8d3-b164-dc24-45e0-8e1bbd550524@stason.org>
On Sun, Sep 23, 2018 at 05:56:03PM -0700, Stas Bekman wrote:
> > You probably want "--ext-diff", not "--textconv".
> [...]
> Would it be safe to ask the maintainer of the application to include
> both --textconv and --ext-diff in that 'git diff-tree' call? I only need
> the latter, but someone needed --textconv there as it's in the code.
I think so. The main reason that they are not the default for plumbing
commands such as diff-tree is that the output may be quite surprising to
anything trying to parse the output. Using --textconv will always
produce a diff, but one that may not be applied to the original content.
Using --ext-diff may produce output that doesn't even look like a diff,
though in practice they often do.
> This is for this package:
> https://github.com/rsmmr/git-notifier
It looks like the output is meant to be read by humans, so yeah, I think
it would be fine (and preferred) to enable both.
-Peff
next prev parent reply other threads:[~2018-09-24 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 22:41 git diff-tree ignores --textconv Stas Bekman
2018-09-24 0:43 ` Jeff King
2018-09-24 0:56 ` Stas Bekman
2018-09-24 1:23 ` Jeff King [this message]
2018-09-24 1:37 ` Stas Bekman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924012354.GA27439@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=stas@stason.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).