From: Jeff King <peff@peff.net>
To: Sebastian Gniazdowski <psprint@zdharma.org>
Cc: git@vger.kernel.org
Subject: Re: Very simple popen() code request, ground-shaking functionality openned by it
Date: Fri, 21 Sep 2018 18:24:54 -0400 [thread overview]
Message-ID: <20180921222454.GD11177@sigill.intra.peff.net> (raw)
In-Reply-To: <315083291.15466.1537536854535@privateemail.com>
On Fri, Sep 21, 2018 at 09:34:14AM -0400, Sebastian Gniazdowski wrote:
> Git default progress indicator for clone is very unattractive, IMO. It
> does its job in providing all the operation details very well, but I
> bet most of users strongly dream about a gauge box!
>
> Have a look at my gauge box constructed as git-stderr pipe script:
> https://asciinema.org/a/202401
>
> The main point of my feature request is: git can add
> core.progress_pipe option, where e.g. `/usr/local/bin/mygauge' will be
> set (a script like the one in the asciinema), and then simply do the
> ground-school-known `popen("/usr/local/bin/mygauge","r+")', and write
> **unchanged current-progress data** to the pipe, then read from the
> pipe and forward to `stderr', where the progress normally lands in.
>
> This will allow users to free their creativity and provide probably
> dozens of custom Git progress bars.
I don't personally feel that the existing progress bar is that bad, but
if anybody wants to pursue this, I think the most sensible path is:
1. Add a trace_key for sending machine-readable progress output to a
descriptor or file. E.g., via setting GIT_TRACE_PROGRESS=2 in the
environment.
2. Teach the trace code to open a command for piping, so that you
could do something like GIT_TRACE_PROGRESS='|mygauge'.
That would make your use case work, and I think many other use cases
would benefit from both of those features independently.
-Peff
next prev parent reply other threads:[~2018-09-21 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 13:34 Very simple popen() code request, ground-shaking functionality openned by it Sebastian Gniazdowski
2018-09-21 22:24 ` Jeff King [this message]
2018-09-21 23:30 ` Ævar Arnfjörð Bjarmason
2018-09-21 23:39 ` Jeff King
2018-09-22 18:16 ` Sebastian Gniazdowski
2018-09-23 13:06 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921222454.GD11177@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=psprint@zdharma.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).