From: frederik@ofb.net
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 0/3] some documentation changes from the beginning of the alphabet
Date: Thu, 20 Sep 2018 22:45:46 -0700 [thread overview]
Message-ID: <20180921054546.GA11082@ofb.net> (raw)
In-Reply-To: <CAPig+cR04cjf-D_hUgKhOSUAhHd8py7BM4-HOyE3VttV_ufXFQ@mail.gmail.com>
> Patches are welcome.
I'd be happy to patch git-contacts to link to the message you just
sent, then maybe someone more qualified would know where to start... :)
Frederick
On Fri, Sep 21, 2018 at 01:18:30AM -0400, Eric Sunshine wrote:
> On Wed, Sep 19, 2018 at 6:49 PM Junio C Hamano <gitster@pobox.com> wrote:
> > Frederick Eaton <frederik@ofb.net> writes:
> > > By the way for some reason git-contacts shows more names when I run it
> > > on the patch hash than when I give it the patch name:
> > >
> > > $ ./contrib/contacts/git-contacts 222580cb60ee64f7b81fed64ec8fbfc81952557f
> > > Sébastien Guimmara <sebastien.guimmara@gmail.com>
> > > Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> > > Eric Sunshine <sunshine@sunshineco.com>
> > > Junio C Hamano <gitster@pobox.com>
> > > $ ./contrib/contacts/git-contacts ./outgoing/0002-git-column.1-clarify-initial-description-provide-exa.patch
> > > Junio C Hamano <gitster@pobox.com>
> >
> > I've never trusted what git-contacts say, but the latter one
> > certainly looks strange [...]
>
> I don't use git-contacts, but the first invocation isn't consulting
> just a single commit but rather a range of commits. From git-contacts
> documentation:
>
> Input consists of one or more patch files or revision arguments.
> A revision argument can be a range or a single `<rev>` which is
> interpreted as `<rev>..HEAD`, thus the same revision arguments
> are accepted as for linkgit:git-format-patch[1]. Patch files and
> revision arguments can be combined in the same invocation.
>
> So, you are actually running git-contacts on the range 222580cb..HEAD,
> and 222580cb isn't even one of the patches being consulted (due to how
> the range syntax does not include the argument to the left of "..").
> To consult just that one commit, you'd want perhaps:
>
> git-contacts 222580cb^..222580cb
>
> > [...] as,
> >
> > git log --no-merges Documentation/git-column.txt
> >
> > makes it clear that I have nothing to do with it ;-). Perhaps the
> > tool gives too much credit for Signed-off-by: footer, or something.
>
> Since git-contacts can be used as git-send-email's --cc-cmd, it can
> potentially be invoked many times, and it's a slow command (due to all
> the "blaming" via git-blame). As an optimization, git-contacts limits
> the timeframe of the blame via git-blame's --since option, with a
> hardcoded limit of 5 years. So, the git-blame invocation made by
> git-contacts for this patch file is:
>
> git blame --porcelain -C -L13,+7 -L23,+7 -L43,+6 \
> --since 5-years-ago \
> 4a189fff51b1^ -- Documentation/git-column.txt
>
> Since the lines changed by the patch have not been touched within that
> timeframe, git-blame assigns those lines to boundary commit 128a96c984
> (Update draft release notes to 1.8.5 for the fifth batch of topics,
> 2013-09-20), which was authored by Junio, which is why he shows up as
> the only "contact".
>
> If we remove the --since restriction:
>
> git blame --porcelain -C -L13,+7 -L23,+7 -L43,+6 \
> 4a189fff51b1^ -- Documentation/git-column.txt
>
> then the lines are correctly "blamed" to Duy via commit 7e29b8254f
> (Add column layout skeleton and git-column, 2012-04-21).
>
> The "Limitations" section of the git-contacts documentation says this:
>
> Several conditions controlling a person's significance are
> currently hard-coded, such as minimum participation level (10%),
> blame date-limiting (5 years), and `-C` level for detecting moved
> and copied lines (a single `-C`). In the future, these conditions
> may become configurable.
>
> So, this sort of potential issue was understood. Felipe's
> git-related[1], from which git-contacts arose, eventually grew the
> ability to tweak these hard-coded values via command-line options. The
> same could be done for git-contacts. Patches are welcome.
>
> [1]: https://github.com/felipec/git-related
>
prev parent reply other threads:[~2018-09-21 5:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 20:12 [PATCH 0/3] some documentation changes from the beginning of the alphabet Frederick Eaton
2018-09-19 20:12 ` [PATCH 1/3] git-archimport.1: specify what kind of Arch we're talking about Frederick Eaton
2018-09-19 22:59 ` Junio C Hamano
2018-09-19 23:13 ` frederik
2018-09-19 20:12 ` [PATCH 2/3] git-column.1: clarify initial description, provide examples Frederick Eaton
2018-09-19 22:59 ` Junio C Hamano
2018-09-20 16:23 ` Duy Nguyen
2018-09-20 17:47 ` frederik
2018-09-21 5:32 ` Eric Sunshine
2018-09-21 16:32 ` Junio C Hamano
2018-09-21 16:48 ` frederik
2018-09-19 20:12 ` [PATCH 3/3] git-describe.1: clarify that "human readable" is also git-readable Frederick Eaton
2018-09-19 22:49 ` [PATCH 0/3] some documentation changes from the beginning of the alphabet Junio C Hamano
2018-09-21 5:18 ` Eric Sunshine
2018-09-21 5:45 ` frederik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921054546.GA11082@ofb.net \
--to=frederik@ofb.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).