From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] Add an EditorConfig file
Date: Thu, 20 Sep 2018 00:00:14 +0000 [thread overview]
Message-ID: <20180920000013.GZ432229@genre.crustytoothpaste.net> (raw)
In-Reply-To: <xmqqtvmm42es.fsf@gitster-ct.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 2045 bytes --]
On Tue, Sep 18, 2018 at 08:00:27PM -0700, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > To make automatically configuring one's editor easier, provide an
> > EditorConfig file. This is an INI-style configuration file that can be
> > used to specify editor settings and can be understood by a wide variety
> > of editors. Some editors include this support natively; others require
> > a plugin.
>
> Good intentions. One thing that makes me wonder is how well this
> plays with "make style" and how easy will it be to keep their
> recommendations in sync. Ideally, if we can generate one from the
> other, or both from a unified source, that would be great.
I think "make style" and the EditorConfig file are complementary. "make
style" autoformats code into a diff. I agree that if we always used
clang-format to format code, then this would be a non-issue in the
EditorConfig file, since we'd just tell people to format their code and
be done with it. However, we don't automatically do that, so I think
this still has value.
(I am having trouble getting make style to work, though, because it
seems to invoke clang-format as a git subcommand, and I don't think that
works. I may send a patch.)
Even if we did that, we couldn't do it for Perl, because the tidy tool
for Perl, perltidy, produces different output depending on version. I
expect we'll have little success in trying to standardize on a given
version.
The EditorConfig file applies to a variety of formats and is designed to
set default editor settings (which users *can* override if they choose).
It applies to any file pattern; for example, as Taylor pointed out, we
could use it to recommend 72-character lines in commit messages.
I agree that maintaining more files is a hassle, but personally, I think
it quite unlikely that we're going to change the Git style, so I feel
the maintenance is fairly low.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2018-09-20 0:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 23:03 [PATCH] Add an EditorConfig file brian m. carlson
2018-09-17 23:18 ` Taylor Blau
2018-09-20 0:05 ` brian m. carlson
2018-09-19 3:00 ` Junio C Hamano
2018-09-20 0:00 ` brian m. carlson [this message]
2018-09-20 14:08 ` Junio C Hamano
2018-09-21 22:50 ` brian m. carlson
2018-09-24 20:05 ` Junio C Hamano
2018-09-27 22:33 ` brian m. carlson
2018-09-21 2:26 ` Eric Sunshine
2018-09-21 2:35 ` Jeff King
2018-09-21 22:19 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920000013.GZ432229@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).