From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 548781F404 for ; Mon, 17 Sep 2018 18:22:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727375AbeIQXuo (ORCPT ); Mon, 17 Sep 2018 19:50:44 -0400 Received: from cloud.peff.net ([104.130.231.41]:51144 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727052AbeIQXun (ORCPT ); Mon, 17 Sep 2018 19:50:43 -0400 Received: (qmail 14951 invoked by uid 109); 17 Sep 2018 18:22:13 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Mon, 17 Sep 2018 18:22:13 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 14763 invoked by uid 111); 17 Sep 2018 18:22:28 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Mon, 17 Sep 2018 14:22:28 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Mon, 17 Sep 2018 14:22:11 -0400 Date: Mon, 17 Sep 2018 14:22:11 -0400 From: Jeff King To: Junio C Hamano Cc: Duy Nguyen , Jonathan Nieder , Git Mailing List , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: What's cooking in git.git (Sep 2018, #03; Fri, 14) Message-ID: <20180917182210.GB3894@sigill.intra.peff.net> References: <20180917023912.GC22024@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Sep 17, 2018 at 10:51:35AM -0700, Junio C Hamano wrote: > Jeff King writes: > > >> > What's the donness of this one? > >> > cf. <20180717201348.GD26218@sigill.intra.peff.net> > >> > >> This topic has stayed in 'pu' for a long time. I thought it was > >> concluded that this was a good change? Jeff, Jonathan? > > > > I read over the thread again. I don't think I actually have any > > complaints about the patches as-is. There was some discussion from Junio > > and Ævar about the third one. I don't have a strong opinion. My > > experience has been that "gc --auto" is garbage anyway on the server > > side, but I think Ævar's experience is that it's reasonable for small to > > medium sites (which seems plausible to me). > > > > The message-id quoted there is my "this looks good". I mentioned a few > > possible nits, but I think it would be OK with or without them > > addressed. > > That matches my reading of your position. I tend to agree with > Ævar's recommendation to postpone 3/3 and use 1 & 2 for now. Let me inject some more uncertainty, then. ;) If we are not going to do 3/3, then should 2/3 simply avoid passing "-1" back via return from main? I guess I don't have a strong opinion, but one of the things I noted was that we converted those die() calls introduced in 2/3 back into returns in 3/3. Do we want to leave it in the state where we are calling die() a lot more? -Peff