From: Antonio Ospite <ao2@ao2.it>
To: gitster@pobox.com
Cc: git@vger.kernel.org, "Brandon Williams" <bmwill@google.com>,
"Daniel Graña" <dangra@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Richard Hartmann" <richih.mailinglist@gmail.com>,
"Stefan Beller" <sbeller@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Antonio Ospite" <ao2@ao2.it>
Subject: [PATCH v5 0/9] Make submodules work if .gitmodules is not checked out
Date: Mon, 17 Sep 2018 16:09:31 +0200 [thread overview]
Message-ID: <20180917140940.3839-1-ao2@ao2.it> (raw)
Hi,
this series teaches git to try and read the .gitmodules file from the
index (:.gitmodules) or from the current branch (HEAD:.gitmodules) when
the file is not readily available in the working tree.
This can be used, together with sparse checkouts, to enable submodule
usage with programs like vcsh[1] which manage multiple repositories with
their working trees sharing the same path.
[1] https://github.com/RichiH/vcsh
v4 of the series is here:
https://public-inbox.org/git/20180824132951.8000-1-ao2@ao2.it/
v3 of the series is here:
https://public-inbox.org/git/20180814110525.17801-1-ao2@ao2.it/
v2 of the series is here:
https://public-inbox.org/git/20180802134634.10300-1-ao2@ao2.it/
v1 of the series, with some background info, is here:
https://public-inbox.org/git/20180514105823.8378-1-ao2@ao2.it/
v5 only contains some small cosmetic fixes suggested by Ævar Arnfjörð
Bjarmason, I ignored the comment about the memory leak in patch
1 because I think there is no leak in how git_config_parse_key is used:
https://public-inbox.org/git/87wosfesxl.fsf@evledraar.gmail.com/
Changes since v4:
* Improve names of local variables in patch 1.
* Move new functions definitions in patches 1 and 2 before
a pre-existing comment instead of after it, as the comment does not
apply to the new functions.
I am repeating the previous changelog below for your convenience, as v3
is what is currently in pu/ao/submodule-wo-gitmodules-checked-out.
Changes between v3 and v4:
* Improve robustness of current tests in t7411-submodule-config.sh:
- merge two tests that check for effects of the same commit.
- reset to a well defined point in history when exiting the tests.
* Fix style issues in new tests added to t7411-submodule-config.sh:
- use test_when_finished in new tests.
- name the output file 'expect' instead of 'expected'.
* Add a new "submodule--helper config --check-writeable" command.
* Use "s--h config --check-wrteable" in git-submodule.sh to share the
code with the C implementation instead of duplicating the safety
check in shell script.
* Add the ability to read .gitmodules from the index and then
fall-back to the current branch if the file is not in the index.
Add also more tests to validate all the possible scenarios.
* Fix style issues in t7416-submodule-sparse-gitmodules.sh:
- name the output file 'expect' instead of 'expected'.
- remove white space after the redirection operator.
- indent the HEREDOC block.
- use "git -C super" instead of a subshell when there is only one
command in the test.
* Remove a stale file named 'new' which erroneously slipped in
a commit.
* Update some comments and commit messages.
Thank you,
Antonio
Antonio Ospite (9):
submodule: add a print_config_from_gitmodules() helper
submodule: factor out a config_set_in_gitmodules_file_gently function
t7411: merge tests 5 and 6
t7411: be nicer to future tests and really clean things up
submodule--helper: add a new 'config' subcommand
submodule: use the 'submodule--helper config' command
t7506: clean up .gitmodules properly before setting up new scenario
submodule: add a helper to check if it is safe to write to .gitmodules
submodule: support reading .gitmodules when it's not in the working
tree
builtin/submodule--helper.c | 40 +++++++++
cache.h | 2 +
git-submodule.sh | 13 ++-
submodule-config.c | 55 ++++++++++++-
submodule-config.h | 2 +
submodule.c | 28 +++++--
submodule.h | 1 +
t/t7411-submodule-config.sh | 107 +++++++++++++++++++++----
t/t7416-submodule-sparse-gitmodules.sh | 78 ++++++++++++++++++
t/t7506-status-submodule.sh | 3 +-
10 files changed, 300 insertions(+), 29 deletions(-)
create mode 100755 t/t7416-submodule-sparse-gitmodules.sh
--
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
next reply other threads:[~2018-09-17 14:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 14:09 Antonio Ospite [this message]
2018-09-17 14:09 ` [PATCH v5 1/9] submodule: add a print_config_from_gitmodules() helper Antonio Ospite
2018-09-24 10:25 ` Antonio Ospite
2018-09-24 23:06 ` Stefan Beller
2018-09-17 14:09 ` [PATCH v5 2/9] submodule: factor out a config_set_in_gitmodules_file_gently function Antonio Ospite
2018-09-17 14:09 ` [PATCH v5 3/9] t7411: merge tests 5 and 6 Antonio Ospite
2018-09-17 14:09 ` [PATCH v5 4/9] t7411: be nicer to future tests and really clean things up Antonio Ospite
2018-09-17 14:09 ` [PATCH v5 5/9] submodule--helper: add a new 'config' subcommand Antonio Ospite
2018-09-17 14:09 ` [PATCH v5 6/9] submodule: use the 'submodule--helper config' command Antonio Ospite
2018-09-17 14:09 ` [PATCH v5 7/9] t7506: clean up .gitmodules properly before setting up new scenario Antonio Ospite
2018-09-17 14:09 ` [PATCH v5 8/9] submodule: add a helper to check if it is safe to write to .gitmodules Antonio Ospite
2018-09-17 14:09 ` [PATCH v5 9/9] submodule: support reading .gitmodules when it's not in the working tree Antonio Ospite
2018-09-18 17:12 ` SZEDER Gábor
2018-09-19 19:24 ` Junio C Hamano
2018-09-20 15:35 ` Antonio Ospite
2018-09-21 16:19 ` Junio C Hamano
2018-09-27 14:49 ` Antonio Ospite
2018-09-24 10:20 ` Antonio Ospite
2018-09-24 21:00 ` Stefan Beller
2018-09-27 14:44 ` Antonio Ospite
2018-09-27 18:00 ` Stefan Beller
2018-10-01 15:45 ` Antonio Ospite
2018-10-01 19:42 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917140940.3839-1-ao2@ao2.it \
--to=ao2@ao2.it \
--cc=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=dangra@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=richih.mailinglist@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).