From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: What's cooking in git.git (Sep 2018, #03; Fri, 14)
Date: Sun, 16 Sep 2018 22:39:13 -0400 [thread overview]
Message-ID: <20180917023912.GC22024@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8DXT8rF_WYE3C0ak7E8_8j=kRS+Yhi1pZjKd5Rr4OsM_A@mail.gmail.com>
On Sun, Sep 16, 2018 at 08:39:03AM +0200, Duy Nguyen wrote:
> On Fri, Sep 14, 2018 at 11:56 PM Junio C Hamano <gitster@pobox.com> wrote:
> > * jn/gc-auto (2018-07-17) 3 commits
> > - gc: do not return error for prior errors in daemonized mode
> > - gc: exit with status 128 on failure
> > - gc: improve handling of errors reading gc.log
> >
> > "gc --auto" ended up calling exit(-1) upon error, which has been
> > corrected to use exit(1). Also the error reporting behaviour when
> > daemonized has been updated to exit with zero status when stopping
> > due to a previously discovered error (which implies there is no
> > point running gc to improve the situation); we used to exit with
> > failure in such a case.
> >
> > What's the donness of this one?
> > cf. <20180717201348.GD26218@sigill.intra.peff.net>
>
> This topic has stayed in 'pu' for a long time. I thought it was
> concluded that this was a good change? Jeff, Jonathan?
I read over the thread again. I don't think I actually have any
complaints about the patches as-is. There was some discussion from Junio
and Ævar about the third one. I don't have a strong opinion. My
experience has been that "gc --auto" is garbage anyway on the server
side, but I think Ævar's experience is that it's reasonable for small to
medium sites (which seems plausible to me).
The message-id quoted there is my "this looks good". I mentioned a few
possible nits, but I think it would be OK with or without them
addressed.
-Peff
next prev parent reply other threads:[~2018-09-17 2:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 21:56 What's cooking in git.git (Sep 2018, #03; Fri, 14) Junio C Hamano
2018-09-15 20:17 ` Antonio Ospite
2018-09-17 15:11 ` Junio C Hamano
2018-09-16 6:39 ` Duy Nguyen
2018-09-16 15:09 ` Ævar Arnfjörð Bjarmason
2018-09-17 2:39 ` Jeff King [this message]
2018-09-17 17:51 ` Junio C Hamano
2018-09-17 18:22 ` Jeff King
2018-09-17 18:26 ` Jonathan Nieder
2018-09-16 12:01 ` brian m. carlson
2018-09-17 15:10 ` Junio C Hamano
2018-09-17 18:35 ` Derrick Stolee
2018-09-17 19:04 ` Junio C Hamano
2018-09-17 22:54 ` Junio C Hamano
2018-09-19 3:49 ` [PATCH] pack-objects: handle island check for "external" delta base Jeff King
2018-09-19 18:34 ` Martin Ågren
2018-09-19 18:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917023912.GC22024@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).