From: Shulhan <m.shulhan@gmail.com>
To: git@vger.kernel.org
Cc: Shulhan <m.shulhan@gmail.com>, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Brandon Williams <bmwill@google.com>
Subject: [RFC PATCH 0/1] builtin/remote: quote remote name on error to display empty name
Date: Wed, 12 Sep 2018 21:45:03 +0700 [thread overview]
Message-ID: <20180912144504.7498-1-m.shulhan@gmail.com> (raw)
Rationale: consistent error format
When adding new remote name with empty string, git will print the
following error message,
fatal: '' is not a valid remote name\n
But when removing remote name with empty string as input, git did not
print the empty string with quote,
fatal: No such remote: \n
Follow up question: If this is ok, should the po files also updated?
This is my first patch, sorry if I did some mistakes.
Shulhan (1):
builtin/remote: quote remote name on error to display empty name
builtin/remote.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
2.19.0.398.gef7f67bed
next reply other threads:[~2018-09-12 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 14:45 Shulhan [this message]
2018-09-12 14:45 ` [RFC PATCH 1/1] builtin/remote: quote remote name on error to display empty name Shulhan
2018-09-12 21:28 ` Junio C Hamano
2018-09-12 16:20 ` [RFC PATCH 0/1] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912144504.7498-1-m.shulhan@gmail.com \
--to=m.shulhan@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).