From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t3701-add-interactive: tighten the check of trace output
Date: Mon, 10 Sep 2018 15:33:34 -0400 [thread overview]
Message-ID: <20180910193333.GA24850@sigill.intra.peff.net> (raw)
In-Reply-To: <20180910191932.GB17224@localhost>
On Mon, Sep 10, 2018 at 09:19:32PM +0200, SZEDER Gábor wrote:
> > I'd have thought that anybody
> > adding index-specific tracing would do it as GIT_TRACE_INDEX.
>
> Depends on the purpose, I guess. For tracing that is aimed to become
> part of in git, definitely. However, for my own ad-hoc tracing used
> to try to make sense of some split-index corner cases, trace_printf()
> is perfect.
I don't mind it as a temporary debug thing, but it would be nice if it
wasn't a temptation for people to include in their actual patches.
-Peff
prev parent reply other threads:[~2018-09-10 19:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 14:07 [PATCH] t3701-add-interactive: tighten the check of trace output SZEDER Gábor
2018-09-10 14:18 ` Taylor Blau
2018-09-18 17:43 ` Taylor Blau
2018-09-10 15:44 ` Jeff King
2018-09-10 17:25 ` Junio C Hamano
2018-09-10 19:19 ` SZEDER Gábor
2018-09-10 19:33 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910193333.GA24850@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).