From: Jeff King <peff@peff.net>
To: Stas Bekman <stas@stason.org>
Cc: git@vger.kernel.org
Subject: Re: git silently ignores include directive with single quotes
Date: Sat, 8 Sep 2018 22:30:23 -0400 [thread overview]
Message-ID: <20180909023023.GB13485@sigill.intra.peff.net> (raw)
In-Reply-To: <7f7e20fd-069d-f227-ce13-811398b52425@stason.org>
On Sat, Sep 08, 2018 at 03:49:01PM -0700, Stas Bekman wrote:
> On 2018-09-08 02:22 PM, Jeff King wrote:
> [...]
> >> The original problem cropped up due to using:
> >>
> >> git config --local include.path '../.gitconfig'
> >>
> >> which on linux stripped the single quotes, but on some windows git bash
> >> emulation it kept them.
> >
> > That sounds like a bug in git bash, if it is not treating single quotes
> > in the usual shell way. But I'd also expect such a bug to cause loads of
> > problems in all of the shell scripts. Are you sure it wasn't cmd.exe or
> > some other interpreter?
>
> I don't know, Jeff. I think the user said it was first anaconda shell.
> And then the user tried gitforwindows with same results. I don't know
> MSwindows at all.
>
> But it doesn't matter at the end of the day, since we can't cover all
> possible unix shell emulations out there. What matters is that there is
> a way to flag the misconfiguration, either by default, or through a
> special check - some ideas I suggested in my previous email, but surely
> you have a much better insight of how to deal with that.
Yes, I agree this is pretty orthogonal to the config discussion. I was
just wondering if there was a separate bug to look into. I'm willing to
shrug and say "it was probably user error" until we see more definite
details. Thanks.
-Peff
next prev parent reply other threads:[~2018-09-09 2:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 18:58 git silently ignores include directive with single quotes Stas Bekman
2018-09-08 19:30 ` Martin Ågren
2018-09-08 19:44 ` Stas Bekman
2018-09-08 19:53 ` Stas Bekman
2018-09-08 20:02 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:13 ` Stas Bekman
2018-09-08 20:28 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:58 ` Stas Bekman
2018-09-09 2:51 ` Paul Smith
2018-09-09 2:57 ` Stas Bekman
2018-09-08 19:54 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:04 ` Stas Bekman
2018-09-08 20:16 ` Ævar Arnfjörð Bjarmason
2018-09-08 21:14 ` Jeff King
2018-09-08 22:10 ` Ramsay Jones
2018-09-09 2:33 ` Jeff King
2018-09-11 20:36 ` Junio C Hamano
2018-09-11 20:57 ` Jeff King
2018-09-23 22:48 ` Stas Bekman
2018-09-24 21:08 ` Ævar Arnfjörð Bjarmason
2018-09-24 23:20 ` Stas Bekman
2018-09-24 22:24 ` [PATCH 0/1] " Philip Oakley
2018-09-24 23:05 ` Stas Bekman
2018-09-24 22:24 ` [PATCH 1/1] config doc: highlight the name=value syntax Philip Oakley
2018-09-25 22:03 ` Junio C Hamano
2018-09-08 22:32 ` git silently ignores include directive with single quotes Ævar Arnfjörð Bjarmason
2018-09-09 2:29 ` Jeff King
2018-09-08 21:22 ` Jeff King
2018-09-08 22:49 ` Stas Bekman
2018-09-09 2:30 ` Jeff King [this message]
2018-09-10 17:04 ` Junio C Hamano
2018-09-10 17:14 ` Jonathan Nieder
2018-09-10 18:30 ` Junio C Hamano
2018-09-10 18:35 ` Jonathan Nieder
2018-09-10 19:17 ` Junio C Hamano
2018-09-10 19:52 ` Stas Bekman
2018-09-10 20:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180909023023.GB13485@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=stas@stason.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).