From: Max Kirillov <max@max630.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Max Kirillov" <max@max630.net>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Jelmer Vernooij" <jelmer@jelmer.uk>,
git@vger.kernel.org, "Jeff King" <peff@peff.net>
Subject: Re: [PATCH] http-backend: allow empty CONTENT_LENGTH
Date: Fri, 7 Sep 2018 06:27:40 +0300 [thread overview]
Message-ID: <20180907032740.GA20545@jessie.local> (raw)
In-Reply-To: <xmqq1sa6z3zp.fsf@gitster-ct.c.googlers.com>
On Thu, Sep 06, 2018 at 02:54:18PM -0700, Junio C Hamano wrote:
> Max Kirillov <max@max630.net> writes:
>> This should fix it. I'm not sure should it treat it as 0 or "-1"
>> At least the tests mentioned by Jeff fails if I try to treat missing CONTENT_LENGTH as "-1"
>> So keep the existing behavior as much as possible
>
> I am not sure what you mean by the above, between 0 and -1. The
> code signals the caller of get_content_length() that req_len is -1
> which is used as a sign to read through to the EOF, so it appears to
> me that the code treats missing content-length (i.e. str == NULL
> case) as "-1".
I made a mistake in this, it should be "if I try to treat missing
CONTENT_LENGTH as 0". This, as far as I understand, what the
RFC specifies.
That is, after the following change, the test "large fetch-pack
requests can be split across POSTs" from t5551 starts faliing:
-- >8 --
@@ -353,8 +353,12 @@ static ssize_t get_content_length(void)
ssize_t val = -1;
const char *str = getenv("CONTENT_LENGTH");
- if (str && *str && !git_parse_ssize_t(str, &val))
- die("failed to parse CONTENT_LENGTH: %s", str);
+ if (str && *str) {
+ if (!git_parse_ssize_t(str, &val))
+ die("failed to parse CONTENT_LENGTH: %s", str);
+ } else
+ val = 0;
+
return val;
}
next prev parent reply other threads:[~2018-09-07 3:27 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f12bc1d7-6acb-6ad9-2917-fbb09105f87a@debian.org>
[not found] ` <20180905202613.GA20473@blodeuwedd>
2018-09-06 6:10 ` CONTENT_LENGTH can no longer be empty Jonathan Nieder
2018-09-06 19:35 ` [PATCH] http-backend: allow empty CONTENT_LENGTH Max Kirillov
2018-09-06 21:54 ` Junio C Hamano
2018-09-07 3:27 ` Max Kirillov [this message]
2018-09-07 3:38 ` Jeff King
2018-09-07 4:20 ` Max Kirillov
2018-09-07 4:59 ` Max Kirillov
2018-09-07 9:49 ` Junio C Hamano
2018-09-08 5:41 ` Max Kirillov
2018-09-09 4:40 ` Max Kirillov
2018-09-06 22:45 ` Jonathan Nieder
2018-09-07 3:36 ` [PATCH v2] " Max Kirillov
2018-09-08 0:19 ` Jonathan Nieder
2018-09-08 5:35 ` Max Kirillov
2018-09-08 5:42 ` [PATCH v3] " Max Kirillov
2018-09-10 5:17 ` Jonathan Nieder
2018-09-10 20:36 ` Max Kirillov
2018-09-11 4:06 ` Jonathan Nieder
2018-09-11 20:33 ` [PATCH v2] http-backend test: make empty CONTENT_LENGTH test more realistic Max Kirillov
2018-09-09 4:10 ` [PATCH v4] http-backend: allow empty CONTENT_LENGTH Max Kirillov
2018-09-10 5:25 ` Jonathan Nieder
2018-09-10 13:17 ` Jeff King
2018-09-10 16:37 ` Junio C Hamano
2018-09-10 18:46 ` Jeff King
2018-09-10 20:53 ` [PATCH] http-backend: Treat empty CONTENT_LENGTH as zero Max Kirillov
2018-09-10 21:22 ` Jonathan Nieder
2018-09-11 1:55 ` Jeff King
2018-09-11 2:20 ` Jonathan Nieder
2018-09-11 2:30 ` Jeff King
2018-09-11 1:58 ` Jeff King
2018-09-11 3:42 ` [PATCH] http-backend: treat " Jonathan Nieder
2018-09-11 4:03 ` Jonathan Nieder
2018-09-11 18:15 ` Junio C Hamano
2018-09-11 18:27 ` Junio C Hamano
2018-09-12 5:56 ` Jeff King
2018-09-12 6:26 ` Jonathan Nieder
2018-09-12 16:10 ` Junio C Hamano
2018-09-11 4:18 ` Junio C Hamano
2018-09-11 4:29 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907032740.GA20545@jessie.local \
--to=max@max630.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jelmer@jelmer.uk \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).