mailing list mirror (one of many)
 help / Atom feed
From: Jonathan Nieder <>
To: Stefan Beller <>
Subject: Re: [PATCH 1/2] submodule.c: convert submodule_move_head new argument to object id
Date: Wed, 5 Sep 2018 16:40:57 -0700
Message-ID: <> (raw)
In-Reply-To: <>

Stefan Beller wrote:

> Subject: submodule.c: convert submodule_move_head new argument to object id

Same nit as in
applies about wondering which subsystem this is in.

> --- a/submodule.c
> +++ b/submodule.c
> @@ -1597,9 +1597,9 @@ static void submodule_reset_index(const char *path)
>   * pass NULL for old or new respectively.
>   */
>  int submodule_move_head(const char *path,
> -			 const char *old_head,
> -			 const char *new_head,
> -			 unsigned flags)
> +			const char *old_head,
> +			const struct object_id *new_oid,
> +			unsigned flags)

This seems oddly asymmetrical.  Should the old value be passed as an
object_id as well?


  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05 23:19 Stefan Beller
2018-09-05 23:19 ` [PATCH 2/2] submodule.c: warn about missing submodule commit in recursive actions Stefan Beller
2018-09-05 23:32   ` Jonathan Nieder
2018-09-06  6:22   ` Martin Ågren
2018-09-05 23:40 ` Jonathan Nieder [this message]
2018-09-06 21:18 ` [PATCH 1/2] submodule.c: convert submodule_move_head new argument to object id Junio C Hamano

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox