From: Matthew DeVore <matvore@google.com>
To: szeder.dev@gmail.com
Cc: avarab@gmail.com, git@vger.kernel.org, gitster@pobox.com,
rybak.a.v@gmail.com
Subject: Re: [PATCH 0/4] tests: make more use of 'test_must_be_empty'
Date: Wed, 22 Aug 2018 10:52:01 -0700 [thread overview]
Message-ID: <20180822175201.42406-1-matvore@google.com> (raw)
In-Reply-To: <20180819215725.29001-1-szeder.dev@gmail.com>
Note that you can also trivially convert a lot more instances of empty
checking to the "right" way: 'test_line_count = 0'
$ grep -Ir 'test_line_count = 0' t | wc -l
76
I think it would be nice to clean these up as well.
prev parent reply other threads:[~2018-08-22 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-19 21:57 [PATCH 0/4] tests: make more use of 'test_must_be_empty' SZEDER Gábor
2018-08-19 21:57 ` [PATCH 1/4] tests: use 'test_must_be_empty' instead of '! test -s' SZEDER Gábor
2018-08-19 21:57 ` [PATCH 2/4] tests: use 'test_must_be_empty' instead of 'test ! -s' SZEDER Gábor
2018-08-19 21:57 ` [PATCH 3/4] tests: use 'test_must_be_empty' instead of 'test_cmp /dev/null <out>' SZEDER Gábor
2018-08-19 21:57 ` [PATCH 4/4] tests: use 'test_must_be_empty' instead of 'test_cmp <empty> <out>' SZEDER Gábor
2018-08-22 17:52 ` Matthew DeVore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822175201.42406-1-matvore@google.com \
--to=matvore@google.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rybak.a.v@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).