From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>,
joakim.tjernlund@infinera.com, git@vger.kernel.org,
bmwill@google.com, pclouds@gmail.com
Subject: Re: [PATCH 1/2] store submodule in common dir
Date: Tue, 14 Aug 2018 17:47:05 -0700 [thread overview]
Message-ID: <20180815004705.GA5932@aiede.svl.corp.google.com> (raw)
In-Reply-To: <xmqqk1osy1qo.fsf@gitster-ct.c.googlers.com>
Junio C Hamano wrote:
> Theoretically we should be able to make modules/kernel%2fv2.[24]
> additional "worktree"s of modules/kernel%2fv2.6, but given that
> these are all "bare" repositories without an attached working tree,
> I am not sure how that would supposed to work. Thinking about
> having multiple worktrees on a single bare repository makes me head
> spin and ache X-<;-)
Agreed about spinning head. This is why I suggested at [1] that
anyone intereseted in this start with description of their proposed
design, which would have three benefits:
- after implementation, it would document the intent behind whatever
we choose to do, hopefully saving people debugging or improving this
code some head spinning
- it would allow subject matter experts on-list to suggest refinements
and simplifications
- it would avoid the interested contributor going too far down a blind
alley in case their initial proposal has a fatal flaw
I also agree with the "theoretically we should be able to make it
work". As described in [1], I think most of this is work we're going
to have to do eventually, as part of properly supporting multiple
worktrees for a superproject. But I don't want to set wrong
expectations: this will be hard.
Thanks,
Jonathan
[1] https://public-inbox.org/git/20180814231049.GH142615@aiede.svl.corp.google.com/
next prev parent reply other threads:[~2018-08-15 0:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 22:27 git submodule: 3 modules same git repo? Joakim Tjernlund
2018-08-14 22:38 ` [PATCH 1/2] store submodule in common dir Stefan Beller
2018-08-14 23:04 ` Junio C Hamano
2018-08-14 23:20 ` Junio C Hamano
2018-08-14 23:30 ` Stefan Beller
2018-08-15 0:47 ` Jonathan Nieder [this message]
2018-08-15 8:28 ` Joakim Tjernlund
2018-08-15 8:39 ` Joakim Tjernlund
2018-08-15 15:20 ` Duy Nguyen
2018-08-14 23:23 ` Stefan Beller
2018-08-14 23:10 ` git submodule: 3 modules same git repo? Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815004705.GA5932@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=joakim.tjernlund@infinera.com \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).