From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id EF69C1F404 for ; Tue, 14 Aug 2018 15:06:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732739AbeHNRxv (ORCPT ); Tue, 14 Aug 2018 13:53:51 -0400 Received: from cloud.peff.net ([104.130.231.41]:54664 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728880AbeHNRxu (ORCPT ); Tue, 14 Aug 2018 13:53:50 -0400 Received: (qmail 25042 invoked by uid 109); 14 Aug 2018 15:06:18 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 14 Aug 2018 15:06:18 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 22914 invoked by uid 111); 14 Aug 2018 15:06:22 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Tue, 14 Aug 2018 11:06:22 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 14 Aug 2018 11:06:16 -0400 Date: Tue, 14 Aug 2018 11:06:16 -0400 From: Jeff King To: Johannes Schindelin Cc: Thomas Gummerer , Thomas Rast via GitGitGadget , git@vger.kernel.org, Junio C Hamano , Thomas Rast Subject: Re: [PATCH v6 11/21] range-diff: add tests Message-ID: <20180814150616.GE3441@sigill.intra.peff.net> References: <1477c58e4c0c9e1d5836ffcb9bcb7360b1a5df0d.1534159977.git.gitgitgadget@gmail.com> <20180813183504.GD13316@hank.intra.tgummerer.com> <20180814150309.GD3441@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180814150309.GD3441@sigill.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Aug 14, 2018 at 11:03:10AM -0400, Jeff King wrote: > > Hmm. I hoped that my commit message was enough to indicate that while he > > is the author, I assembled this. Maybe I should move him to the footer, as > > an Original-Authored-By:? > > I think the "Author" field is actually distinct from the copyright > provenance. In this case it ought to be perfectly fine to add your > signed-off-by under the DCO's point b: > > The contribution is based upon previous work that, to the best > of my knowledge, is covered under an appropriate open source > license and I have the right under that license to submit that > work with modifications [...] > > This is based on the tests in tbdiff, which is explicitly GPL'd by > Thomas. So your signoff certifies that, which is fine. > > As for the author field, IMHO it serves two purposes: > > - to give credit where it is due > > - so that people digging in history know who to contact for > questions/problems > > In this case it probably makes sense for it to be you, as you'd take > responsibility for the code in _this_ project. And as you note, you can > give credit in the commit message (the only unfortunate thing is that > most automated statistics would not credit Thomas, but in theory they > could by mentioning him in the trailer). One thing I should have made clear: this is all my opinion, and anything Thomas expresses trumps that. But since he hasn't been active lately, this is all what I would do in the absence of input from him. Obviously a sign-off from him is better than none. :) -Peff