From: Jeff King <peff@peff.net>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: Git mailing list <git@vger.kernel.org>
Subject: Re: [RFC PATCH] packfile: iterate packed objects in pack order
Date: Fri, 10 Aug 2018 18:59:18 -0400 [thread overview]
Message-ID: <20180810225918.GA18913@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGf8dgK_yMEtyh+_chQ+9i2d1Uc9oAXr7Q_8ES5OPF8qF87EHw@mail.gmail.com>
On Thu, Aug 09, 2018 at 03:03:24PM -0700, Jonathan Tan wrote:
> On Wed, Aug 8, 2018 at 4:25 PM, Jeff King <peff@peff.net> wrote:
> > Even if you just use the oid to do a separate lookup in the object
> > database, there's still a benefit in accessing the objects in pack
> > order.
>
> You're probably right, but I don't immediately see what the benefit is.
>
> On a not completely unrelated note, I just realized that in my patch,
> i should be pack_nr (ordinal in pack order) and pack_nr should be
> index_nr (ordinal in index order, i.e. alphabetical order). If you run
> with this, feel free to write your own patch and maybe I'll learn how
> accessing objects in pack order benefits looking up the object
> database through the commit message.
It probably would have been more apparent if when I said "like in the
patch below" I actually remembered to paste in the patch. ;)
> > I can try to pick this up and carry the cat-file bits to completion if
> > you want, but probably not until tomorrow or Friday.
>
> Thanks - feel free to do this.
I've got a series which I'll post momentarily which hopefully explains
what's going on, along with various timings.
-Peff
prev parent reply other threads:[~2018-08-10 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 23:12 [RFC PATCH] packfile: iterate packed objects in pack order Jonathan Tan
2018-08-08 23:25 ` Jeff King
2018-08-09 22:03 ` Jonathan Tan
2018-08-10 22:59 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810225918.GA18913@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).