From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jeff King" <peff@peff.net>, "Karel Kočí" <karel.koci@nic.cz>,
"Santiago Torres" <santiago@nyu.edu>,
"Vojtech Myslivec" <vojtech.myslivec@nic.cz>,
git@vger.kernel.org
Subject: Re: [PATCH 1/1] verify-tag/verify-commit should exit unsuccessfully when signature is not trusted
Date: Thu, 9 Aug 2018 01:43:02 +0000 [thread overview]
Message-ID: <20180809014302.GB34639@genre.crustytoothpaste.net> (raw)
In-Reply-To: <xmqqzhxwcq2o.fsf@gitster-ct.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]
On Wed, Aug 08, 2018 at 05:59:43PM -0700, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> >> FWIW, I'm on board with returning non-zero in any case where gpg would.
> >
> > I think that's probably the best solution overall.
>
> FWIW, I am not married to the current behaviour. I would not be
> surprised if it mostly came by accident and not designed.
Since apparently I was the author of the commit that changed the
behavior originally, let me simply say that I was not aware that gpg
signalled the correctness of a signature by its exit status when I wrote
that patch. If I had known that, I would have deferred to gpg in my
change. My goal was consistency between verify-tag and verify-commit,
and in retrospect I probably made the wrong decision.
> > There's a bug report
> > in Debian (https://bugs.debian.org/895048) that requests that behavior
> > instead of the status quo, and also it's the behavior that's documented:
>
> The last bit is a bit questionable; I think you are reading too much
> into the description.
>
> A substitute for gpg.program MUST signal good (or not good)
> signature the same way as gpg would with its exit code---that is all
> the description says. It does not say anything about how that exit
> code affects the exit status of "tag --verify" and friends that
> called gpg.program.
I agree that the description doesn't specifically say that. In fact, it
doesn't explicitly say that it must exit nonzero on a bad signature,
although I agree with your interpretation that that would be logical
(and, AIUI, the behavior of gpg).
However, I would assert that we do want Git's verification to exit
successfully on a good signature and unsuccessfully on a bad signature,
and deferring to gpg may be the most robust way of ensuring that.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]
next prev parent reply other threads:[~2018-08-09 1:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 20:05 [PATCH 1/1] verify-tag/verify-commit should exit unsuccessfully when signature is not trusted Vojtech Myslivec
2018-08-01 0:19 ` brian m. carlson
2018-08-01 0:25 ` Santiago Torres
2018-08-03 13:36 ` Karel Kočí
2018-08-03 15:43 ` Santiago Torres
2018-08-03 16:06 ` Jeff King
2018-08-04 8:43 ` Karel Kočí
2018-08-08 23:04 ` Jeff King
2018-08-08 23:12 ` brian m. carlson
2018-08-09 0:59 ` Junio C Hamano
2018-08-09 1:43 ` brian m. carlson [this message]
2018-08-09 14:30 ` Jeff King
2018-08-09 15:30 ` Junio C Hamano
2018-08-09 17:12 ` Jeff King
2018-08-09 18:40 ` Junio C Hamano
2018-08-09 19:50 ` Jeff King
2018-08-10 2:27 ` brian m. carlson
2018-08-13 15:14 ` Vojtech Myslivec
2018-08-03 17:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809014302.GB34639@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karel.koci@nic.cz \
--cc=peff@peff.net \
--cc=santiago@nyu.edu \
--cc=vojtech.myslivec@nic.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).