From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org
Cc: hvoigt@hvoigt.net, Stefan Beller <sbeller@google.com>
Subject: [PATCH 02/10] string-list.h: add string_list_pop function.
Date: Wed, 8 Aug 2018 15:17:44 -0700 [thread overview]
Message-ID: <20180808221752.195419-3-sbeller@google.com> (raw)
In-Reply-To: <20180808221752.195419-1-sbeller@google.com>
A string list can be used as a stack, but should we? A later patch shows
how useful this will be.
Signed-off-by: Stefan Beller <sbeller@google.com>
---
string-list.c | 8 ++++++++
string-list.h | 6 ++++++
2 files changed, 14 insertions(+)
diff --git a/string-list.c b/string-list.c
index 9f651bb4294..ea80afc8a0c 100644
--- a/string-list.c
+++ b/string-list.c
@@ -80,6 +80,14 @@ void string_list_remove(struct string_list *list, const char *string,
}
}
+struct string_list_item *string_list_pop(struct string_list *list)
+{
+ if (list->nr == 0)
+ return 0;
+
+ return &list->items[--list->nr];
+}
+
int string_list_has_string(const struct string_list *list, const char *string)
{
int exact_match;
diff --git a/string-list.h b/string-list.h
index ff8f6094a33..a1a41bc961a 100644
--- a/string-list.h
+++ b/string-list.h
@@ -191,6 +191,12 @@ extern void string_list_remove(struct string_list *list, const char *string,
*/
struct string_list_item *string_list_lookup(struct string_list *list, const char *string);
+/**
+ * Returns the last item inserted and removes it from the list.
+ * If the list is empty, return NULL.
+ */
+struct string_list_item *string_list_pop(struct string_list *list);
+
/*
* Remove all but the first of consecutive entries with the same
* string value. If free_util is true, call free() on the util
--
2.18.0.597.ga71716f1ad-goog
next prev parent reply other threads:[~2018-08-08 22:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 22:17 [RFC PATCH 00/10] fetch: make sure submodule oids are fetched Stefan Beller
2018-08-08 22:17 ` [PATCH 01/10] string_list: print_string_list to use trace_printf Stefan Beller
2018-08-09 21:16 ` Junio C Hamano
2018-08-09 21:40 ` Stefan Beller
2018-08-08 22:17 ` Stefan Beller [this message]
2018-08-09 7:35 ` [PATCH 02/10] string-list.h: add string_list_pop function Martin Ågren
2018-08-09 21:29 ` Junio C Hamano
2018-08-09 21:41 ` Jeff King
2018-08-09 21:52 ` Stefan Beller
2018-08-09 21:56 ` Jeff King
2018-08-09 22:10 ` Stefan Beller
2018-08-08 22:17 ` [PATCH 03/10] sha1-array: provide oid_array_remove_if Stefan Beller
2018-08-09 7:39 ` Martin Ågren
2018-08-09 17:25 ` Stefan Beller
2018-08-09 19:24 ` Jeff King
2018-08-09 21:46 ` Junio C Hamano
2018-08-09 21:44 ` Junio C Hamano
2018-08-08 22:17 ` [PATCH 04/10] submodule.c: convert submodule_move_head new argument to object id Stefan Beller
2018-08-09 22:00 ` Junio C Hamano
2018-08-08 22:17 ` [PATCH 05/10] submodule.c: fix indentation Stefan Beller
2018-08-08 22:17 ` [PATCH 06/10] submodule.c: sort changed_submodule_names before searching it Stefan Beller
2018-08-08 22:17 ` [PATCH 07/10] submodule: move global changed_submodule_names into fetch submodule struct Stefan Beller
2018-08-08 22:17 ` [PATCH 08/10] submodule.c: do not copy around submodule list Stefan Beller
2018-08-08 22:17 ` [PATCH 09/10] submodule: fetch in submodules git directory instead of in worktree Stefan Beller
2018-08-08 22:17 ` [PATCH 10/10] fetch: retry fetching submodules if sha1 were not fetched Stefan Beller
2018-08-09 7:50 ` Martin Ågren
2018-08-09 17:42 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808221752.195419-3-sbeller@google.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).