From: Jonathan Nieder <jrnieder@gmail.com>
To: Edward Thomson <ethomson@edwardthomson.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 0/1] Introduce git-recover
Date: Sat, 4 Aug 2018 18:34:22 -0700 [thread overview]
Message-ID: <20180805013422.GC258270@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20180804142247.GA7@e3c0ce5ceb57>
Hi,
Edward Thomson wrote:
> I created a simple shell script a while back to help people recover
> files that they deleted from their working directory (but had been added
> to the repository), which looks for unreachable blobs in the object
> database and places them in the working directory (either en masse,
> interactively, or via command-line arguments).
Cool! Most of this belongs in the commit message, which is part of why
I always discourage having a separate cover letter in single-patch
series.
> This has been available at https://github.com/ethomson/git-recover for
> about a year, and in that time, someone has suggested that I propose
> this as part of git itself. So I thought I'd see if there's any
> interest in this.
>
> If there is, I'd like to get a sense of the amount of work required to
> make this suitable for inclusion. There are some larger pieces of work
> required -- at a minimum, I think this requires:
>
> - Tests -- there are none, which is fine with me but probably less fine
> for inclusion here.
> - Documentation -- the current README is below but it will need proper
> documentation that can be rendered into manpages, etc, by the tools.
> - Remove bashisms -- there are many.
One possible path in that direction would be to "stage" the code in
contrib/ first, while documenting the intention of graduating to a
command in git itself. Then the list can pitch in with those tasks.
There are good reasons for a tool to exist outside of Git, so I
wouldn't recommend this unless we have a clear plan for its graduation
that we've agreed upon as a project, but thought I should mention it
as a mechanism in case we decide to do that.
The trend these days for Git commands has been to prefer to have them
in C. Portable shell is a perfectly fine stopping point on the way
there, though.
My more fundamental main thought is separate from those logistics: how
does this relate to "git fsck --lost-found"? What would your ideal
interface to solve this problem look like? Can we make Git's commands
complement each other in a good way to solve it well?
Thanks,
Jonathan
prev parent reply other threads:[~2018-08-05 1:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 14:22 [RFC PATCH 0/1] Introduce git-recover Edward Thomson
2018-08-04 14:24 ` [RFC PATCH 1/1] recover: restoration of deleted worktree files Edward Thomson
2018-08-04 15:54 ` Junio C Hamano
2018-08-04 16:17 ` Robert P. J. Day
2018-08-04 17:33 ` Todd Zullinger
2018-08-04 16:19 ` Edward Thomson
2018-08-04 16:48 ` Junio C Hamano
2018-08-05 1:34 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180805013422.GC258270@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=ethomson@edwardthomson.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).