Re: Git clone and case sensitivity

[Simon Ruderich <simon@ruderich.org>]

On Sat, Jul 28, 2018 at 07:11:05AM +0200, Duy Nguyen wrote:
>  static int checkout(int submodule_progress)
>  {
>  	struct object_id oid;
> @@ -761,6 +785,11 @@ static int checkout(int submodule_progress)
>  	if (write_locked_index(&the_index, &lock_file, COMMIT_LOCK))
>  		die(_("unable to write new index file"));
>
> +	if (ignore_case && has_duplicate_icase_entries(&the_index))
> +		warning(_("This repository has paths that only differ in case\n"
> +			  "and you have a case-insenitive filesystem which will\n"
> +			  "cause problems."));
> +
>  	err |= run_hook_le(NULL, "post-checkout", sha1_to_hex(null_sha1),
>  			   oid_to_hex(&oid), "1", NULL);

I think the advice message should list the problematic file
names. Even though this might be quite verbose it will help those
affected to quickly find the problematic files to either fix this
on their own or report to upstream (unless there's already an
easy way to find those files - if so it should be mentioned in
the message).

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9