From: Jonathan Nieder <jrnieder@gmail.com>
To: Beat Bolli <dev+git@drbeat.li>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/2] packfile: drop a repeated enum declaration
Date: Tue, 24 Jul 2018 14:57:36 -0700 [thread overview]
Message-ID: <20180724215736.GC136514@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20180724215223.27516-2-dev+git@drbeat.li>
Hi,
Beat Bolli wrote:
> --- a/packfile.h
> +++ b/packfile.h
> @@ -6,7 +6,6 @@
> /* in object-store.h */
> struct packed_git;
> struct object_info;
> -enum object_type;
>
> /*
> * Generate the filename to be used for a pack file with checksum "sha1" and
Good catch. This means packfile.h should #include "cache.h" ---
otherwise, it is not usable in a file that does
#include "git-compat-util.h"
#include "packfile.h"
Thanks and hope that helps,
Jonathan
next prev parent reply other threads:[~2018-07-24 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 21:52 [PATCH 0/2] Pedantic fixes for Apple clang Beat Bolli
2018-07-24 21:52 ` [PATCH 1/2] packfile: drop a repeated enum declaration Beat Bolli
2018-07-24 21:57 ` Jonathan Nieder [this message]
2018-07-24 21:52 ` [PATCH 2/2] remote-odb: un-inline function remote_odb_reinit Beat Bolli
2018-07-24 21:59 ` Jonathan Nieder
2018-07-24 22:03 ` Beat Bolli
2018-07-25 7:29 ` Christian Couder
2018-07-25 21:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724215736.GC136514@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).