From: Brandon Williams <bmwill@google.com>
To: git@vger.kernel.org
Subject: Re: [RFC] push: add documentation on push v2
Date: Tue, 24 Jul 2018 12:28:11 -0700 [thread overview]
Message-ID: <20180724192811.GC225275@google.com> (raw)
In-Reply-To: <20180717210915.139521-1-bmwill@google.com>
On 07/17, Brandon Williams wrote:
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>
> Since introducing protocol v2 and enabling fetch I've been thinking
> about what its inverse 'push' would look like. After talking with a
> number of people I have a longish list of things that could be done to
> improve push and I think I've been able to distill the core features we
> want in push v2. Thankfully (due to the capability system) most of the
> other features/improvements can be added later with ease.
>
> What I've got now is a rough design for a more flexible push, more
> flexible because it allows for the server to do what it wants with the
> refs that are pushed and has the ability to communicate back what was
> done to the client. The main motivation for this is to work around
> issues when working with Gerrit and other code-review systems where you
> need to have Change-Ids in the commit messages (now the server can just
> insert them for you and send back new commits) and you need to push to
> magic refs to get around various limitations (now a Gerrit server should
> be able to communicate that pushing to 'master' doesn't update master
> but instead creates a refs/changes/<id> ref).
>
> Before actually moving to write any code I'm hoping to get some feedback
> on if we think this is an acceptable base design for push (other
> features like atomic-push, signed-push, etc can be added as
> capabilities), so any comments are appreciated.
>
> Documentation/technical/protocol-v2.txt | 76 +++++++++++++++++++++++++
> 1 file changed, 76 insertions(+)
Pinging this thread again to hopefully reach some more people for
commentary. Looking back through the comments so far there are concerns
that a server shouldn't be trusted rewriting my local changes, so to
address that we could have the be a config option which is defaulted to
not take changes from a server.
Apart from that I didn't see any other major concerns. I'm hoping to
get a bit more discussion going before actually beginning work on this.
--
Brandon Williams
next prev parent reply other threads:[~2018-07-24 19:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 21:09 [RFC] push: add documentation on push v2 Brandon Williams
2018-07-17 23:25 ` Stefan Beller
2018-07-18 13:31 ` Derrick Stolee
2018-07-18 16:56 ` Stefan Beller
2018-07-18 17:15 ` Brandon Williams
2018-07-20 13:12 ` Jeff Hostetler
2018-07-24 19:00 ` Brandon Williams
2018-07-18 17:11 ` Brandon Williams
2018-07-18 17:19 ` Duy Nguyen
2018-07-18 17:46 ` Brandon Williams
2018-07-18 17:57 ` Duy Nguyen
2018-07-18 17:08 ` Brandon Williams
2018-07-18 18:07 ` Stefan Beller
2018-07-18 18:17 ` Duy Nguyen
2018-07-18 18:21 ` Brandon Williams
2018-07-24 19:28 ` Brandon Williams [this message]
2018-07-25 15:15 ` Duy Nguyen
2018-07-25 17:46 ` Brandon Williams
2018-08-02 15:17 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724192811.GC225275@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).