From: Christian Couder <christian.couder@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Christian Couder <chriscool@tuxfamily.org>
Subject: [RFC PATCH 1/5] packfile: make get_delta_base() non static
Date: Sun, 22 Jul 2018 07:48:32 +0200 [thread overview]
Message-ID: <20180722054836.28935-2-chriscool@tuxfamily.org> (raw)
In-Reply-To: <20180722054836.28935-1-chriscool@tuxfamily.org>
From: Jeff King <peff@peff.net>
As get_delta_base() will be used outside 'packfile.c' in
a following commit, let's make it non static and let's
declare it in 'packfile.h'.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
packfile.c | 10 +++++-----
packfile.h | 3 +++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/packfile.c b/packfile.c
index 7cd45aa4b2..4646bff5ff 100644
--- a/packfile.c
+++ b/packfile.c
@@ -1037,11 +1037,11 @@ const struct packed_git *has_packed_and_bad(const unsigned char *sha1)
return NULL;
}
-static off_t get_delta_base(struct packed_git *p,
- struct pack_window **w_curs,
- off_t *curpos,
- enum object_type type,
- off_t delta_obj_offset)
+off_t get_delta_base(struct packed_git *p,
+ struct pack_window **w_curs,
+ off_t *curpos,
+ enum object_type type,
+ off_t delta_obj_offset)
{
unsigned char *base_info = use_pack(p, w_curs, *curpos, NULL);
off_t base_offset;
diff --git a/packfile.h b/packfile.h
index cc7eaffe1b..30f0811382 100644
--- a/packfile.h
+++ b/packfile.h
@@ -125,6 +125,9 @@ extern void *unpack_entry(struct repository *r, struct packed_git *, off_t, enum
extern unsigned long unpack_object_header_buffer(const unsigned char *buf, unsigned long len, enum object_type *type, unsigned long *sizep);
extern unsigned long get_size_from_delta(struct packed_git *, struct pack_window **, off_t);
extern int unpack_object_header(struct packed_git *, struct pack_window **, off_t *, unsigned long *);
+extern off_t get_delta_base(struct packed_git *p, struct pack_window **w_curs,
+ off_t *curpos, enum object_type type,
+ off_t delta_obj_offset);
extern void release_pack_memory(size_t);
--
2.18.0.237.gffdb1dbdaa
next prev parent reply other threads:[~2018-07-22 5:49 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-22 5:48 [RFC PATCH 0/5] Add delta islands support Christian Couder
2018-07-22 5:48 ` Christian Couder [this message]
2018-07-24 16:19 ` [RFC PATCH 1/5] packfile: make get_delta_base() non static Junio C Hamano
2018-07-27 11:29 ` Jeff King
2018-07-22 5:48 ` [RFC PATCH 2/5] Add delta-islands.{c,h} Christian Couder
2018-07-22 8:50 ` Duy Nguyen
2018-07-22 13:57 ` Christian Couder
2018-08-05 18:53 ` Christian Couder
2018-08-06 14:17 ` Jeff King
2018-08-06 15:53 ` Duy Nguyen
2018-08-06 18:54 ` Christian Couder
2018-08-06 19:21 ` Duy Nguyen
2018-07-24 16:47 ` Junio C Hamano
2018-07-27 13:02 ` Jeff King
2018-07-27 9:40 ` Jeff King
2018-07-22 5:48 ` [RFC PATCH 3/5] pack-objects: add delta-islands support Christian Couder
2018-07-22 8:55 ` Duy Nguyen
2018-08-05 17:28 ` Christian Couder
2018-07-23 18:52 ` Stefan Beller
2018-07-24 9:58 ` Jeff King
2018-07-24 17:20 ` Stefan Beller
2018-07-27 13:13 ` Jeff King
2018-07-27 17:22 ` Stefan Beller
2018-07-28 9:00 ` Jeff King
2018-07-28 12:12 ` Christian Couder
2018-07-24 17:03 ` Junio C Hamano
2018-07-24 17:11 ` Junio C Hamano
2018-08-05 17:40 ` Christian Couder
2018-08-06 8:44 ` Christian Couder
2018-08-06 13:58 ` Jeff King
2018-07-22 5:48 ` [RFC PATCH 4/5] repack: " Christian Couder
2018-07-22 5:48 ` [RFC PATCH 5/5] t: add t9930-delta-islands.sh Christian Couder
2018-07-24 10:24 ` Jeff King
2018-07-24 10:16 ` [RFC PATCH 0/5] Add delta islands support Jeff King
2018-07-24 17:18 ` Junio C Hamano
2018-07-24 21:14 ` Jeff King
2018-07-26 13:34 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180722054836.28935-2-chriscool@tuxfamily.org \
--to=christian.couder@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).