mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Beat Bolli <>
Cc:, Beat Bolli <>
Subject: [PATCH] Makefile: add a DEVOPTS flag to get pedantic compilation
Date: Sat, 21 Jul 2018 20:59:33 +0200	[thread overview]
Message-ID: <> (raw)

In the interest of code hygiene, make it easier to compile Git with the
flag -pedantic.

Pure pedantic compilation results in one warning per use of the
translation macro `N_`, therefore also disable the parenthesising of
i18n strings with -DUSE_PARENS_AROUND_GETTEXT_N=0 to show only real

Signed-off-by: Beat Bolli <>

This is the convenience knob for all developers that led to the series
bb/pedantic[1]. It does not depend on this series, though.


 Makefile       | 4 ++++ | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/Makefile b/Makefile
index 0cb6590f24..f800054379 100644
--- a/Makefile
+++ b/Makefile
@@ -484,6 +484,10 @@ all::
 #        The DEVELOPER mode enables -Wextra with a few exceptions. By
 #        setting this flag the exceptions are removed, and all of
 #        -Wextra is used.
+#    pedantic:
+#        Enable -pedantic compilation.
diff --git a/ b/
index 2d244ca470..f21f0d0209 100644
--- a/
+++ b/
@@ -1,6 +1,10 @@
 ifeq ($(filter no-error,$(DEVOPTS)),)
 CFLAGS += -Werror
+ifneq ($(filter pedantic,$(DEVOPTS)),)
+CFLAGS += -pedantic
+# don't warn for each N_ use
 CFLAGS += -Wdeclaration-after-statement
 CFLAGS += -Wno-format-zero-length
 CFLAGS += -Wold-style-definition

             reply	other threads:[~2018-07-21 18:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-21 18:59 Beat Bolli [this message]
2018-07-21 19:41 ` [PATCH] Makefile: add a DEVOPTS flag to get pedantic compilation Ævar Arnfjörð Bjarmason
2018-07-23 18:51   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).