No rule to make target `git-daemon'

No rule to make target `git-daemon'

[Jeffrey Walton]

Hi Everyone,

I'm working from the 2.18 tarball on Solaris 11.3 x86_64. I'm catching
the following when building from sources. This appears to be a new
issue. It was not present in 2.17.1.

    gmake: *** No rule to make target `git-daemon'.  Stop.
    gmake: *** Waiting for unfinished jobs....
    Failed to build Git

There does not appear to be an option to control building the daemon:

    $ ./configure --help | grep -i daemon
    $

Any ideas on how to side-step it?

Thanks in advance

Re: No rule to make target `git-daemon'

[Eric Sunshine]

On Thu, Jul 19, 2018 at 9:37 PM Jeffrey Walton <noloader@gmail.com> wrote:
> I'm working from the 2.18 tarball on Solaris 11.3 x86_64. I'm catching
> the following when building from sources. This appears to be a new
> issue. It was not present in 2.17.1.
>
>     gmake: *** No rule to make target `git-daemon'.  Stop.
>     gmake: *** Waiting for unfinished jobs....
>     Failed to build Git

Unable to reproduce this problem. Is your Makefile corrupt or
truncated or something?

Re: No rule to make target `git-daemon'

[brian m. carlson]

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

On Thu, Jul 19, 2018 at 09:37:08PM -0400, Jeffrey Walton wrote:
> Hi Everyone,
> 
> I'm working from the 2.18 tarball on Solaris 11.3 x86_64. I'm catching
> the following when building from sources. This appears to be a new
> issue. It was not present in 2.17.1.
> 
>     gmake: *** No rule to make target `git-daemon'.  Stop.
>     gmake: *** Waiting for unfinished jobs....
>     Failed to build Git
> 
> There does not appear to be an option to control building the daemon:
> 
>     $ ./configure --help | grep -i daemon
>     $
> 
> Any ideas on how to side-step it?

I also don't see this issue, and I didn't see anything between 2.17.1
and 2.18 that stood out to me as a potential cause of this problem.  Can
you tell us a bit more about what version of GNU make you're using and
the configuration you're trying to build (say, the config.mak.autogen)?
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]

Re: No rule to make target `git-daemon'

[Jeff King]

On Thu, Jul 19, 2018 at 09:37:08PM -0400, Jeffrey Walton wrote:

> I'm working from the 2.18 tarball on Solaris 11.3 x86_64. I'm catching
> the following when building from sources. This appears to be a new
> issue. It was not present in 2.17.1.
> 
>     gmake: *** No rule to make target `git-daemon'.  Stop.
>     gmake: *** Waiting for unfinished jobs....
>     Failed to build Git

Like others, I don't really have an idea on how this could have
happened. But perhaps "gmake -d git-daemon" could be enlightening?

Mine has:

  [...]
  Considering target file 'git-daemon'.
   Looking for an implicit rule for 'git-daemon'.
   Trying pattern rule with stem 'daemon'.
   Trying implicit prerequisite 'daemon.o'.
   Trying rule prerequisite 'GIT-LDFLAGS'.
   Trying rule prerequisite 'common-main.o'.
   Trying rule prerequisite 'libgit.a'.
   Trying rule prerequisite 'xdiff/lib.a'.
   Found an implicit rule for 'git-daemon'.
    Considering target file 'daemon.o'.

and so on.

> There does not appear to be an option to control building the daemon:
> 
>     $ ./configure --help | grep -i daemon
>     $
> 
> Any ideas on how to side-step it?

There's no official knob to turn, but dropping this line would remove
it:

diff --git a/Makefile b/Makefile
index 08e5c54549..31153a2789 100644
--- a/Makefile
+++ b/Makefile
@@ -684,7 +684,6 @@ EXTRA_PROGRAMS =
 PROGRAMS += $(EXTRA_PROGRAMS)
 
 PROGRAM_OBJS += credential-store.o
-PROGRAM_OBJS += daemon.o
 PROGRAM_OBJS += fast-import.o
 PROGRAM_OBJS += http-backend.o
 PROGRAM_OBJS += imap-send.o

-Peff

Re: No rule to make target `git-daemon'

[Jeffrey Walton]

On Fri, Jul 20, 2018 at 5:04 PM, brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> On Thu, Jul 19, 2018 at 09:37:08PM -0400, Jeffrey Walton wrote:
>> Hi Everyone,
>>
>> I'm working from the 2.18 tarball on Solaris 11.3 x86_64. I'm catching
>> the following when building from sources. This appears to be a new
>> issue. It was not present in 2.17.1.
>>
>>     gmake: *** No rule to make target `git-daemon'.  Stop.
>>     gmake: *** Waiting for unfinished jobs....
>>     Failed to build Git
>>
>> There does not appear to be an option to control building the daemon:
>>
>>     $ ./configure --help | grep -i daemon
>>     $
>>
>> Any ideas on how to side-step it?
>
> I also don't see this issue, and I didn't see anything between 2.17.1
> and 2.18 that stood out to me as a potential cause of this problem.  Can
> you tell us a bit more about what version of GNU make you're using and
> the configuration you're trying to build (say, the config.mak.autogen)?

Sorry about the late reply. I meant to reply this morning.

My shell script to patch things on Solaris was the cause of the problem.

(If anyone is interested in first class Solaris support then I am
happy to help. The patch set needed for the platform has been stable
for the last couple of years).

Jeff

Re: No rule to make target `git-daemon'

[brian m. carlson]

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

On Fri, Jul 20, 2018 at 05:51:46PM -0400, Jeffrey Walton wrote:
> Sorry about the late reply. I meant to reply this morning.
> 
> My shell script to patch things on Solaris was the cause of the problem.

Glad to hear you got it figured out.

> (If anyone is interested in first class Solaris support then I am
> happy to help. The patch set needed for the platform has been stable
> for the last couple of years).

I'd certainly be interested for you to send it to the list.  I'm not
sure I can provide a helpful review, since I don't run Solaris, but
having better support out of the box would definitely be nice.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]

Re: No rule to make target `git-daemon'

[Johannes Schindelin]

Hi,

On Fri, 20 Jul 2018, brian m. carlson wrote:

> On Fri, Jul 20, 2018 at 05:51:46PM -0400, Jeffrey Walton wrote:
> 
> > (If anyone is interested in first class Solaris support then I am
> > happy to help. The patch set needed for the platform has been stable
> > for the last couple of years).
> 
> I'd certainly be interested for you to send it to the list.  I'm not
> sure I can provide a helpful review, since I don't run Solaris, but
> having better support out of the box would definitely be nice.

The cURL team has some SunOS build IIRC that was nicely integrated with
their GitHub-based CI. Maybe we could have something similar?

Ciao,
Dscho