git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, rybak.a.v@gmail.com,
	Stefan Beller <sbeller@google.com>
Subject: [PATCH 05/10] diff.c: adjust hash function signature to match hashmap expectation
Date: Wed, 18 Jul 2018 12:31:51 -0700	[thread overview]
Message-ID: <20180718193156.47365-6-sbeller@google.com> (raw)
In-Reply-To: <20180718193156.47365-1-sbeller@google.com>

This makes the follow up patch easier.

Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 diff.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/diff.c b/diff.c
index ce7bedc1b92..d1bae900cdc 100644
--- a/diff.c
+++ b/diff.c
@@ -707,11 +707,15 @@ struct moved_entry {
 	struct moved_entry *next_line;
 };
 
-static int moved_entry_cmp(const struct diff_options *diffopt,
-			   const struct moved_entry *a,
-			   const struct moved_entry *b,
+static int moved_entry_cmp(const void *hashmap_cmp_fn_data,
+			   const void *entry,
+			   const void *entry_or_key,
 			   const void *keydata)
 {
+	const struct diff_options *diffopt = hashmap_cmp_fn_data;
+	const struct moved_entry *a = entry;
+	const struct moved_entry *b = entry_or_key;
+
 	return !xdiff_compare_lines(a->es->line, a->es->len,
 				    b->es->line, b->es->len,
 				    diffopt->xdl_opts);
@@ -5534,10 +5538,8 @@ static void diff_flush_patch_all_file_pairs(struct diff_options *o)
 		if (o->color_moved) {
 			struct hashmap add_lines, del_lines;
 
-			hashmap_init(&del_lines,
-				     (hashmap_cmp_fn)moved_entry_cmp, o, 0);
-			hashmap_init(&add_lines,
-				     (hashmap_cmp_fn)moved_entry_cmp, o, 0);
+			hashmap_init(&del_lines, moved_entry_cmp, o, 0);
+			hashmap_init(&add_lines, moved_entry_cmp, o, 0);
 
 			add_lines_to_move_detection(o, &add_lines, &del_lines);
 			mark_color_as_moved(o, &add_lines, &del_lines);
-- 
2.18.0.233.g985f88cf7e-goog


  parent reply	other threads:[~2018-07-18 19:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 19:31 [PATCHv6 00/10] Reroll of sb/diff-color-move-more Stefan Beller
2018-07-18 19:31 ` [PATCH 01/10] xdiff/xdiff.h: remove unused flags Stefan Beller
2018-07-18 19:31 ` [PATCH 02/10] xdiff/xdiffi.c: remove unneeded function declarations Stefan Beller
2018-07-18 19:31 ` [PATCH 03/10] t4015: avoid git as a pipe input Stefan Beller
2018-07-18 19:31 ` [PATCH 04/10] diff.c: do not pass diff options as keydata to hashmap Stefan Beller
2018-07-18 19:31 ` Stefan Beller [this message]
2018-07-18 19:31 ` [PATCH 06/10] diff.c: add a blocks mode for moved code detection Stefan Beller
2018-07-18 19:31 ` [PATCH 07/10] diff.c: decouple white space treatment from move detection algorithm Stefan Beller
2018-07-18 19:31 ` [PATCH 08/10] diff.c: factor advance_or_nullify out of mark_color_as_moved Stefan Beller
2018-07-18 19:31 ` [PATCH 09/10] diff.c: add white space mode to move detection that allows indent changes Stefan Beller
2018-07-18 19:31 ` [PATCH 10/10] diff.c: offer config option to control ws handling in move detection Stefan Beller
2018-07-19 19:05 ` [PATCHv6 00/10] Reroll of sb/diff-color-move-more Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180718193156.47365-6-sbeller@google.com \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rybak.a.v@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).