From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id EAF361F597 for ; Mon, 16 Jul 2018 16:18:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728466AbeGPQqb (ORCPT ); Mon, 16 Jul 2018 12:46:31 -0400 Received: from cloud.peff.net ([104.130.231.41]:48014 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727184AbeGPQqb (ORCPT ); Mon, 16 Jul 2018 12:46:31 -0400 Received: (qmail 2541 invoked by uid 109); 16 Jul 2018 16:18:12 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Mon, 16 Jul 2018 16:18:12 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 12990 invoked by uid 111); 16 Jul 2018 16:18:27 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Mon, 16 Jul 2018 12:18:27 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Mon, 16 Jul 2018 12:18:22 -0400 Date: Mon, 16 Jul 2018 12:18:22 -0400 From: Jeff King To: Ramsay Jones Cc: Johannes Schindelin , Derrick Stolee via GitGitGadget , git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH 00/16] Consolidate reachability logic Message-ID: <20180716161821.GB18150@sigill.intra.peff.net> References: <6b7a50dc-6b71-0e31-030a-42dd1b26bde4@ramsayjones.plus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6b7a50dc-6b71-0e31-030a-42dd1b26bde4@ramsayjones.plus.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jul 16, 2018 at 02:54:38PM +0100, Ramsay Jones wrote: > On 16/07/18 14:00, Derrick Stolee via GitGitGadget wrote: > > There are many places in Git that use a commit walk to determine > > reachability between commits and/or refs. A lot of this logic is > > duplicated. > [snip] ... > > This is not your problem, but I find these GitGitGadget > submissions somewhat annoying. This series has been spewed > all over my in-box in, what I assume, is commit date order. > > So, patches #4,5 dated 19/06, then #1,2,3 dated 25/06, > then #15 dated 28/06, then #6,7 dated 12/07, then #8-16 > dated 13/07, then 00/16 dated today. > > No I don't use a threaded display (I hate it), be even with > that turned on, the patches still appear in the above order > under the cover letter (but at least all together). Yeah, they're out of order in mutt's threaded display. And the back-dating means there's a much higher chance of them getting blocked as spam (e.g., some of the dates are from weeks ago). git-send-email uses the current time minus an offset, and then monotonically increases for each patch: $time = time - scalar $#files; ... my $date = format_2822_time($time++); which seems to work pretty well in practice. It does mean the original dates are lost. The committer date is not interesting at all (there will be a new committer via "git am" anyway). The original author date is potentially of interest, but could be included as an in-body header. AFAIK send-email doesn't have such an option, though, and people are fine with date-of-sending becoming the new author date. +cc Johannes as the GitGitGadget author -Peff