git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jules Maselbas <jules.maselbas@grenoble-inp.org>
To: git@vger.kernel.org
Cc: Jules Maselbas <jules.maselbas@grenoble-inp.org>
Subject: [PATCH] send-email: Fix tls AUTH when sending batch
Date: Sat, 14 Jul 2018 04:14:40 +0200	[thread overview]
Message-ID: <20180714021440.22995-1-jules.maselbas@grenoble-inp.org> (raw)

The variable smtp_encryption must keep it's value between two batches.
Otherwise the authentication is skipped after the first batch.

Signed-off-by: Jules Maselbas <jules.maselbas@grenoble-inp.org>
---
 git-send-email.perl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index 8ec70e58e..543e18145 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1501,7 +1501,6 @@ sub send_message {
 					$smtp->starttls(ssl_verify_params())
 						or die sprintf(__("STARTTLS failed! %s"), IO::Socket::SSL::errstr());
 				}
-				$smtp_encryption = '';
 				# Send again to receive fresh
 				# supported commands
 				$smtp->hello($smtp_domain);
-- 
2.18.0


             reply	other threads:[~2018-07-14  2:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-14  2:14 Jules Maselbas [this message]
2018-07-14  8:58 ` [PATCH v2] send-email: Fix tls AUTH when sending batch Jules Maselbas
2018-07-16 22:19   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180714021440.22995-1-jules.maselbas@grenoble-inp.org \
    --to=jules.maselbas@grenoble-inp.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).