From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 5BCBF1F85E for ; Fri, 13 Jul 2018 19:24:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730070AbeGMTkl (ORCPT ); Fri, 13 Jul 2018 15:40:41 -0400 Received: from cloud.peff.net ([104.130.231.41]:58776 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1730017AbeGMTkl (ORCPT ); Fri, 13 Jul 2018 15:40:41 -0400 Received: (qmail 32409 invoked by uid 109); 13 Jul 2018 19:24:44 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 13 Jul 2018 19:24:44 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 6389 invoked by uid 111); 13 Jul 2018 19:24:46 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Fri, 13 Jul 2018 15:24:46 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 13 Jul 2018 15:24:42 -0400 Date: Fri, 13 Jul 2018 15:24:42 -0400 From: Jeff King To: William Chargin Cc: Junio C Hamano , Git Mailing List , Duy Nguyen Subject: Re: [PATCH v2] sha1-name.c: for ":/", find detached HEAD commits Message-ID: <20180713192441.GA10354@sigill.intra.peff.net> References: <20180712054909.29077-1-wchargin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jul 12, 2018 at 01:01:23PM -0700, William Chargin wrote: > Contents look good to me. I don't understand why the file name in your > patch is sha1_name.c as opposed to sha1-name.c (I see e5e5e0883 from > 2018-04-10, but that sounds pretty old), but I trust that whatever > you're doing there is correct. Junio typically applies bugfixes as close to the bug-source as possible, which allows them to be merged-up into various releases (rather than cherry-picked, which would be required if built on top of 'master'). Ideally this is directly on top of the commit that introduced the bug, though for an ancient bug like this, it's not worth the effort. It looks like he applied it on the 2.16 maint branch, which predates e5e5e0883. When it's merged up, the resolution will handle the rename (probably even automatically due to Git's rename detection). > > Thanks for working on this. > > You're quite welcome. Thanks to you, Peff, and Duy for your help. This > was a pleasant experience for me as a new contributor. :-) Great. Please come back anytime. :) -Peff