From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Ben Peart <Ben.Peart@microsoft.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"gitster@pobox.com" <gitster@pobox.com>,
"peff@peff.net" <peff@peff.net>,
"stolee@gmail.com" <stolee@gmail.com>
Subject: Re: [PATCH v2] convert log_ref_write_fd() to use strbuf
Date: Fri, 13 Jul 2018 18:12:28 +0000 [thread overview]
Message-ID: <20180713181228.GB968742@genre.crustytoothpaste.net> (raw)
In-Reply-To: <20180710210806.23384-1-benpeart@microsoft.com>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Tue, Jul 10, 2018 at 09:08:22PM +0000, Ben Peart wrote:
> Since we don't care about how many bytes were written, simplify the return
> value logic.
>
> log_ref_write_fd() was written long before strbuf was fleshed out. Remove
> the old manual buffer management code and replace it with strbuf(). Also
> update copy_reflog_msg() which is called only by log_ref_write_fd() to use
> strbuf as it keeps things consistent.
>
> Signed-off-by: Ben Peart <Ben.Peart@microsoft.com>
This looks good to me. Thanks for the patch.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]
prev parent reply other threads:[~2018-07-13 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 18:20 [PATCH v1] convert log_ref_write_fd() to use strbuf Ben Peart
2018-07-10 18:45 ` Jeff King
2018-07-10 19:41 ` Junio C Hamano
2018-07-10 20:21 ` Jeff King
2018-07-10 20:57 ` Ben Peart
2018-07-10 21:08 ` [PATCH v2] " Ben Peart
2018-07-10 21:22 ` Junio C Hamano
2018-07-13 18:12 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713181228.GB968742@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=Ben.Peart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).