On Tue, Jul 10, 2018 at 02:08:28PM -0400, Ben Peart wrote: > > > On 7/9/2018 7:39 PM, brian m. carlson wrote: > > On Mon, Jul 09, 2018 at 10:45:33AM -0700, Junio C Hamano wrote: > > > As Brandon alludes to downthread, we probably should use strbuf for > > > things like this these days, so a preliminary clean-up to do so is > > > probably a welcome change to sneak in and rebase this series on top > > > of. > > > > Sure, I agree that would be a better change, and I'm happy to reroll > > with that. > > > > I've put together a patch to update log_ref_write_fd() to use strbuf and > will submit it shortly. Excellent. I'll drop this patch in that case. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204