git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Perry Hutchison <perryh@pluto.rain.com>,
	Johannes.Schindelin@gmx.de, git@vger.kernel.org,
	paul@mad-scientist.net, dnj@google.com
Subject: Re: Git 2.18: RUNTIME_PREFIX... is it working?
Date: Tue, 10 Jul 2018 15:20:05 -0700	[thread overview]
Message-ID: <20180710222005.GP14196@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20180710140310.GA9246@sigill.intra.peff.net>

Hi,

Jeff King wrote:

> My point is that aside from RUNTIME_PREFIX, we don't need /proc. So
> somebody who currently builds Git with a static path like
> "/usr/libexec/git-core" and runs it inside a chroot will be just fine as
> long as /usr/libexec/git-core is available at that name inside the
> chroot. But if the build starts relying on RUNTIME_PREFIX, it's going to
> regress their case.
>
> I'm not sure how hypothetical this is. A lot of Debian tools use chroots
> to build packages for specific releases by basically installing the
> distro inside the chroot. I don't know whether /proc is available in
> those chroots or not. If not, then I suspect builds that rely on
> installing Git inside the chroot are going to break.
>
> +cc Jonathan, who maintains the Git package for Debian, and can probably
> say immediately whether I am way off base. ;)

The chroots typically have /proc.

Various libc features also count on /proc being mounted, though in
general libc tries to handle the case when it isn't mounted
gracefully.  Similarly, various features of other tools (like bash's
support for <(echo hi)) also rely on /proc.

If this is the main obstacle to enabling RUNTIME_PREFIX by default,
one option would be to make RUNTIME_PREFIX fall back to a hard-coded
path when and only when git is not able to find the path from which it
was run.  That would increase complexity, though, so I am not thrilled
with the idea.

I might try enabling RUNTIME_PREFIX in Debian experimental's git and
seeing what breaks. ;-)

Thanks,
Jonathan

  reply	other threads:[~2018-07-10 22:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04  5:12 Git 2.18: RUNTIME_PREFIX... is it working? Paul Smith
2018-07-04 11:22 ` Johannes Schindelin
2018-07-05 15:36   ` Paul Smith
2018-07-06  9:00     ` Johannes Schindelin
2018-07-06 13:18       ` Daniel Jacques
2018-07-08 18:52         ` Paul Smith
2018-07-08 21:52           ` Johannes Schindelin
2018-07-09 19:58             ` Jeff King
2018-07-09 20:26               ` Johannes Schindelin
2018-07-10  2:21                 ` Jeff King
2018-07-10 11:40                   ` Johannes Schindelin
2018-07-10 14:03                     ` Daniel Jacques
2018-07-10 16:09                       ` Junio C Hamano
2018-07-09 21:05               ` Junio C Hamano
2018-07-10  3:56               ` Jeff King
2018-07-10  7:13                 ` Perry Hutchison
2018-07-10 14:03                   ` Jeff King
2018-07-10 22:20                     ` Jonathan Nieder [this message]
2018-07-10 22:21                       ` Jonathan Nieder
2018-07-17  9:45                       ` Johannes Schindelin
2018-07-14 20:51                     ` brian m. carlson
2018-07-18 12:18                       ` Johannes Schindelin
2018-07-19 22:26                         ` brian m. carlson
2018-07-20 14:29                           ` Jeff Hostetler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180710222005.GP14196@aiede.svl.corp.google.com \
    --to=jrnieder@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=dnj@google.com \
    --cc=git@vger.kernel.org \
    --cc=paul@mad-scientist.net \
    --cc=peff@peff.net \
    --cc=perryh@pluto.rain.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).