From: Jeff King <peff@peff.net>
To: David Turner <novalis@novalis.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: git log --shortstat doesn't respect -c (but --stat does)
Date: Tue, 10 Jul 2018 16:34:38 -0400 [thread overview]
Message-ID: <20180710203438.GB6886@sigill.intra.peff.net> (raw)
In-Reply-To: <1531251974.28120.90.camel@novalis.org>
On Tue, Jul 10, 2018 at 03:46:14PM -0400, David Turner wrote:
> This seems inconsistent:
>
> $ git log --oneline --stat 91ccfb85176 -c
> 91ccfb8517 Merge branch 'sb/diff-color-move'
>
> diff.c | 28 +++++++++++++++-------------
> t/t4015-diff-whitespace.sh | 9 +++++++++
> 2 files changed, 24 insertions(+), 13 deletions(-)
> d1114d87c7 Merge branch 'js/rebase-i-final'
>
> sequencer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> ...
>
> $ git log --oneline --shortstat 91ccfb85176 -c
> 91ccfb8517 Merge branch 'sb/diff-color-move'
Yeah. Definitely a bug.
The patch below seems to fix it, but:
- it may need similar treatment around DIRSTAT
- we should probably have a pre-defined mask for stat formats so it
doesn't have to be repeated everywhere
I'm logging off for the day in a bit, but maybe somebody wants to
investigate further?
diff --git a/combine-diff.c b/combine-diff.c
index 2ef495963f..dc6183958a 100644
--- a/combine-diff.c
+++ b/combine-diff.c
@@ -1331,7 +1331,7 @@ static struct combine_diff_path *find_paths_generic(const struct object_id *oid,
* combined diff.
*/
int stat_opt = (output_format &
- (DIFF_FORMAT_NUMSTAT|DIFF_FORMAT_DIFFSTAT));
+ (DIFF_FORMAT_NUMSTAT|DIFF_FORMAT_DIFFSTAT|DIFF_FORMAT_SHORTSTAT));
if (i == 0 && stat_opt)
opt->output_format = stat_opt;
else
@@ -1459,7 +1459,7 @@ void diff_tree_combined(const struct object_id *oid,
* when doing combined diff.
*/
stat_opt = (opt->output_format &
- (DIFF_FORMAT_NUMSTAT|DIFF_FORMAT_DIFFSTAT));
+ (DIFF_FORMAT_NUMSTAT|DIFF_FORMAT_DIFFSTAT|DIFF_FORMAT_SHORTSTAT));
if (stat_opt) {
diffopts.output_format = stat_opt;
@@ -1504,7 +1504,7 @@ void diff_tree_combined(const struct object_id *oid,
needsep = 1;
}
else if (opt->output_format &
- (DIFF_FORMAT_NUMSTAT|DIFF_FORMAT_DIFFSTAT))
+ (DIFF_FORMAT_NUMSTAT|DIFF_FORMAT_DIFFSTAT|DIFF_FORMAT_SHORTSTAT))
needsep = 1;
else if (opt->output_format & DIFF_FORMAT_CALLBACK)
handle_combined_callback(opt, paths, num_parent, num_paths);
-Peff
prev parent reply other threads:[~2018-07-10 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 19:46 git log --shortstat doesn't respect -c (but --stat does) David Turner
2018-07-10 20:34 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710203438.GB6886@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=novalis@novalis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).