From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Paul Smith <paul@mad-scientist.net>,
Daniel Jacques <dnj@google.com>,
git@vger.kernel.org
Subject: Re: Git 2.18: RUNTIME_PREFIX... is it working?
Date: Mon, 9 Jul 2018 22:21:41 -0400 [thread overview]
Message-ID: <20180710022141.GC10248@sigill.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1807092225120.75@tvgsbejvaqbjf.bet>
On Mon, Jul 09, 2018 at 10:26:54PM +0200, Johannes Schindelin wrote:
> > Would it be reasonable to make RUNTIME_PREFIX the default on systems
> > where we _do_ have that support? AFAIK there is no downside to having it
> > enabled (minus a few syscalls to find the prefix, I suppose, but I
> > assume that's negligible).
> >
> > I.e., a patch to config.mak.uname (and possibly better support for
> > _disabling_ it, though I think "make RUNTIME_PREFIX=" would probably
> > work).
>
> The obvious downside is that we would be a lot more likely to break one
> side of the equation. At least right now, we have Git for Windows being a
> prime user of RUNTIME_PREFIX (so breakages should be caught relatively
> quickly), and macOS/Linux *not* being users of that feature (so breakages
> in the non-RUNTIME_PREFIX code paths should be caught even quicker). By
> turning on RUNTIME_PREFIX for the major platforms, the fringe platforms
> are even further out on their own.
That's true. On the other hand, we have a zillion compat features for
fringe platforms already, so there already is an expectation that people
on those platforms would need to occasionally report and fix
system-specific bugs. Perhaps thinking of it not as an feature to opt
into, but rather as a compat for "your system has not caught up to the
modern world by implementing RUNTIME_PREFIX" would encourage people on
those platforms to implement the necessary scaffolding.
I also have a gut feeling that it is much easier for static-path devs to
break RUNTIME_PREFIX folks, rather than the other way around, simply
because RUNTIME_PREFIX has a lot more moving parts. But I admit that's
just a feeling.
-Peff
next prev parent reply other threads:[~2018-07-10 2:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 5:12 Git 2.18: RUNTIME_PREFIX... is it working? Paul Smith
2018-07-04 11:22 ` Johannes Schindelin
2018-07-05 15:36 ` Paul Smith
2018-07-06 9:00 ` Johannes Schindelin
2018-07-06 13:18 ` Daniel Jacques
2018-07-08 18:52 ` Paul Smith
2018-07-08 21:52 ` Johannes Schindelin
2018-07-09 19:58 ` Jeff King
2018-07-09 20:26 ` Johannes Schindelin
2018-07-10 2:21 ` Jeff King [this message]
2018-07-10 11:40 ` Johannes Schindelin
2018-07-10 14:03 ` Daniel Jacques
2018-07-10 16:09 ` Junio C Hamano
2018-07-09 21:05 ` Junio C Hamano
2018-07-10 3:56 ` Jeff King
2018-07-10 7:13 ` Perry Hutchison
2018-07-10 14:03 ` Jeff King
2018-07-10 22:20 ` Jonathan Nieder
2018-07-10 22:21 ` Jonathan Nieder
2018-07-17 9:45 ` Johannes Schindelin
2018-07-14 20:51 ` brian m. carlson
2018-07-18 12:18 ` Johannes Schindelin
2018-07-19 22:26 ` brian m. carlson
2018-07-20 14:29 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710022141.GC10248@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=dnj@google.com \
--cc=git@vger.kernel.org \
--cc=paul@mad-scientist.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).