From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 9BA8C1F62D for ; Fri, 6 Jul 2018 00:54:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753963AbeGFAyH (ORCPT ); Thu, 5 Jul 2018 20:54:07 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:40271 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753927AbeGFAyC (ORCPT ); Thu, 5 Jul 2018 20:54:02 -0400 Received: by mail-qk0-f193.google.com with SMTP id b129-v6so5504400qke.7 for ; Thu, 05 Jul 2018 17:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WeTOpijTpOnE2iSUOCcX5t6+zX5i9OJHaGjFF5vOwNU=; b=gsdaoxVLGNaVK3V2k9tjJjZS2mVFYJvyIlfRNW5jH7E+JAFFqkzHcwzMrfMZVkna1B nfo2myzzfGMENSxUC6dprM6jXAN71y7mAW+Lon8CxtLDSCiBJ7pF1YFzcWbhVxioRH/8 YhswYHLU5yTr96Tzkt8Sn+bqQXYm0bLQqH5yM+I3XRRORcPE2AbPq1LPgAV1VsqNd5ia /ua5BzEPwXugLguzV4nGpDUvirbf0Kjo+N3Kb++BJVEmSZpq1XU59vDc4rmAySmi2fv4 U9Lr61hqK4SI0DcyGCq4A2U+0PWupPj4jI06OU0f9x0zeFnq70jCiq71gXcyVYt8Co4/ I0QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WeTOpijTpOnE2iSUOCcX5t6+zX5i9OJHaGjFF5vOwNU=; b=GAkyOMWn1WxKUPRAWIRun83hWXB7+x+CDaDlTc0qUyUzIu3gMTL1ZWeBrQGjR+XMmm ro4qcGJi448A3BFNopCvMZFqGJwi7WtmqB9h3LFmKt8R9CnxmSIexDqStCHWMYnrPlW2 nfk/e3a1n0Cc1Ta4C1cpuqXvDWgiK/OcCJ+XB8v3z85YjxH2/PAwhypgY/yj9XwkNZUo n+LEijR2lciHCT6B/4mAavvL7d97CI7W2TqXh8aullFoZQBeQDQljkJ1IVtMb17ntPaB 5lXCyf+gIMo/ulYkouWz0Ce7P/Tp67K0Zh3Fh2pohpdewZaAzHbo8lxZ4H/gERgUmzrN gJlQ== X-Gm-Message-State: APt69E3y1QocWyJVkw7nVygjSZaMRbRcF94dZio4/OjYuhZdqlW7HskF nRkVlA8X0eqZLMtAI7XDGsfA2fu5 X-Google-Smtp-Source: AAOMgpdn1AgraaS5ngAKmz2DXbgw+sGl/H5IcnMNh3xOje7qVwqLs8BJp6Iz53vHqkDsiF3MSyOxXw== X-Received: by 2002:a37:444a:: with SMTP id r71-v6mr7015638qka.79.1530838441787; Thu, 05 Jul 2018 17:54:01 -0700 (PDT) Received: from stolee-linux-2.corp.microsoft.com ([2001:4898:8010:0:eb4a:5dff:fe0f:730f]) by smtp.gmail.com with ESMTPSA id u25-v6sm4882791qku.3.2018.07.05.17.54.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jul 2018 17:54:01 -0700 (PDT) From: Derrick Stolee X-Google-Original-From: Derrick Stolee To: git@vger.kernel.org Cc: gitster@pobox.com, sbeller@google.com, pclouds@gmail.com, avarab@gmail.com, dstolee@microsoft.com Subject: [PATCH v3 18/24] midx: read objects from multi-pack-index Date: Thu, 5 Jul 2018 20:53:15 -0400 Message-Id: <20180706005321.124643-19-dstolee@microsoft.com> X-Mailer: git-send-email 2.18.0.118.gd4f65b8d14 In-Reply-To: <20180706005321.124643-1-dstolee@microsoft.com> References: <20180625143434.89044-1-dstolee@microsoft.com> <20180706005321.124643-1-dstolee@microsoft.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Signed-off-by: Derrick Stolee --- midx.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++++- midx.h | 2 ++ object-store.h | 1 + packfile.c | 8 ++++- 4 files changed, 100 insertions(+), 2 deletions(-) diff --git a/midx.c b/midx.c index d5a61c0c53..84b045060a 100644 --- a/midx.c +++ b/midx.c @@ -4,7 +4,7 @@ #include "lockfile.h" #include "packfile.h" #include "object-store.h" -#include "packfile.h" +#include "sha1-lookup.h" #include "midx.h" #define MIDX_SIGNATURE 0x4d494458 /* "MIDX" */ @@ -152,6 +152,7 @@ struct multi_pack_index *load_multi_pack_index(const char *object_dir) m->num_objects = ntohl(m->chunk_oid_fanout[255]); m->pack_names = xcalloc(m->num_packs, sizeof(*m->pack_names)); + m->packs = xcalloc(m->num_packs, sizeof(*m->packs)); cur_pack_name = (const char *)m->chunk_pack_names; for (i = 0; i < m->num_packs; i++) { @@ -180,6 +181,94 @@ struct multi_pack_index *load_multi_pack_index(const char *object_dir) return NULL; } +static int prepare_midx_pack(struct multi_pack_index *m, uint32_t pack_int_id) +{ + struct strbuf pack_name = STRBUF_INIT; + + if (pack_int_id >= m->num_packs) + BUG("bad pack-int-id"); + + if (m->packs[pack_int_id]) + return 0; + + strbuf_addf(&pack_name, "%s/pack/%s", m->object_dir, + m->pack_names[pack_int_id]); + + m->packs[pack_int_id] = add_packed_git(pack_name.buf, pack_name.len, 1); + strbuf_release(&pack_name); + return !m->packs[pack_int_id]; +} + +int bsearch_midx(const struct object_id *oid, struct multi_pack_index *m, uint32_t *result) +{ + return bsearch_hash(oid->hash, m->chunk_oid_fanout, m->chunk_oid_lookup, + MIDX_HASH_LEN, result); +} + +static off_t nth_midxed_offset(struct multi_pack_index *m, uint32_t pos) +{ + const unsigned char *offset_data; + uint32_t offset32; + + offset_data = m->chunk_object_offsets + pos * MIDX_CHUNK_OFFSET_WIDTH; + offset32 = get_be32(offset_data + sizeof(uint32_t)); + + if (m->chunk_large_offsets && offset32 & MIDX_LARGE_OFFSET_NEEDED) { + if (sizeof(offset32) < sizeof(uint64_t)) + die(_("multi-pack-index stores a 64-bit offset, but off_t is too small")); + + offset32 ^= MIDX_LARGE_OFFSET_NEEDED; + return get_be64(m->chunk_large_offsets + sizeof(uint64_t) * offset32); + } + + return offset32; +} + +static uint32_t nth_midxed_pack_int_id(struct multi_pack_index *m, uint32_t pos) +{ + return get_be32(m->chunk_object_offsets + pos * MIDX_CHUNK_OFFSET_WIDTH); +} + +static int nth_midxed_pack_entry(struct multi_pack_index *m, struct pack_entry *e, uint32_t pos) +{ + uint32_t pack_int_id; + struct packed_git *p; + + if (pos >= m->num_objects) + return 0; + + pack_int_id = nth_midxed_pack_int_id(m, pos); + + if (prepare_midx_pack(m, pack_int_id)) + die(_("error preparing packfile from multi-pack-index")); + p = m->packs[pack_int_id]; + + /* + * We are about to tell the caller where they can locate the + * requested object. We better make sure the packfile is + * still here and can be accessed before supplying that + * answer, as it may have been deleted since the MIDX was + * loaded! + */ + if (!is_pack_valid(p)) + return 0; + + e->offset = nth_midxed_offset(m, pos); + e->p = p; + + return 1; +} + +int fill_midx_entry(const struct object_id *oid, struct pack_entry *e, struct multi_pack_index *m) +{ + uint32_t pos; + + if (!bsearch_midx(oid, m, &pos)) + return 0; + + return nth_midxed_pack_entry(m, e, pos); +} + int prepare_multi_pack_index_one(struct repository *r, const char *object_dir) { struct multi_pack_index *m = r->objects->multi_pack_index; diff --git a/midx.h b/midx.h index 731ad6f094..6b74a0640f 100644 --- a/midx.h +++ b/midx.h @@ -6,6 +6,8 @@ struct multi_pack_index; struct multi_pack_index *load_multi_pack_index(const char *object_dir); +int bsearch_midx(const struct object_id *oid, struct multi_pack_index *m, uint32_t *result); +int fill_midx_entry(const struct object_id *oid, struct pack_entry *e, struct multi_pack_index *m); int prepare_multi_pack_index_one(struct repository *r, const char *object_dir); int write_midx_file(const char *object_dir); diff --git a/object-store.h b/object-store.h index 7d67ad7aa9..03cc278758 100644 --- a/object-store.h +++ b/object-store.h @@ -106,6 +106,7 @@ struct multi_pack_index { const unsigned char *chunk_large_offsets; const char **pack_names; + struct packed_git **packs; char object_dir[FLEX_ARRAY]; }; diff --git a/packfile.c b/packfile.c index 5d4493dbf4..bc763d91b9 100644 --- a/packfile.c +++ b/packfile.c @@ -1902,11 +1902,17 @@ static int fill_pack_entry(const struct object_id *oid, int find_pack_entry(struct repository *r, const struct object_id *oid, struct pack_entry *e) { struct list_head *pos; + struct multi_pack_index *m; prepare_packed_git(r); - if (!r->objects->packed_git) + if (!r->objects->packed_git && !r->objects->multi_pack_index) return 0; + for (m = r->objects->multi_pack_index; m; m = m->next) { + if (fill_midx_entry(oid, e, m)) + return 1; + } + list_for_each(pos, &r->objects->packed_git_mru) { struct packed_git *p = list_entry(pos, struct packed_git, mru); if (fill_pack_entry(oid, e, p)) { -- 2.18.0.118.gd4f65b8d14